Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(audits): removed unused audit meta.category #3554

Merged
merged 2 commits into from
Oct 18, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/recipes/custom-audit/searchable-audit.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const MAX_SEARCHABLE_TIME = 4000;
class LoadAudit extends Audit {
static get meta() {
return {
category: 'MyCustomCategory',
name: 'searchable-audit',
description: 'Search box initialized and ready',
failureDescription: 'Search box slow to initialize',
Expand Down
2 changes: 0 additions & 2 deletions lighthouse-cli/test/smokehouse/smokehouse.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ function collateResults(actual, expected) {
const diff = findDifference(auditName, actualResult, expectedResult);

return {
category: auditName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the two in this file are a different category and should stay :)

actual: actualResult,
expected: expectedResult,
equal: !diff,
Expand All @@ -206,7 +205,6 @@ function collateResults(actual, expected) {

return {
finalUrl: {
category: 'final url',
actual: actual.url,
expected: expected.url,
equal: actual.url === expected.url,
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/accesskeys.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class Accesskeys extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'accesskeys',
description: '`[accesskey]` values are unique.',
failureDescription: '`[accesskey]` values are not unique.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/aria-allowed-attr.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ARIAAllowedAttr extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-allowed-attr',
description: '`[aria-*]` attributes match their roles.',
failureDescription: '`[aria-*]` attributes do not match their roles.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/aria-required-attr.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ARIARequiredAttr extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-required-attr',
description: '`[role]`s have all required `[aria-*]` attributes.',
failureDescription: '`[role]`s do not have all required `[aria-*]` attributes.',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class AriaRequiredChildren extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-required-children',
description: 'Elements with `[role]` that require specific children `[role]`s, are present.',
failureDescription: 'Elements with `[role]` that require specific children `[role]`s, ' +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class AriaRequiredParent extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-required-parent',
description: '`[role]`s are contained by their required parent element.',
failureDescription: '`[role]`s are not contained by their required parent element.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/aria-roles.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class AriaRoles extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-roles',
description: '`[role]` values are valid.',
failureDescription: '`[role]` values are not valid.',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ARIAValidAttr extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-valid-attr-value',
description: '`[aria-*]` attributes have valid values.',
failureDescription: '`[aria-*]` attributes do not have valid values.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/aria-valid-attr.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ARIAValidAttr extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'aria-valid-attr',
description: '`[aria-*]` attributes are valid and not misspelled.',
failureDescription: '`[aria-*]` attributes are not valid or misspelled.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/audio-caption.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class AudioCaption extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'audio-caption',
description: '`<audio>` elements contain a `<track>` element with `[kind="captions"]`.',
failureDescription: '`<audio>` elements are missing a `<track>` element with ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/button-name.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ButtonName extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'button-name',
description: 'Buttons have an accessible name.',
failureDescription: 'Buttons do not have an accessible name.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/bypass.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class Bypass extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'bypass',
description: 'The page contains a heading, skip link, or landmark region.',
failureDescription: 'The page does not contain a heading, skip link, or landmark region.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/color-contrast.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class ColorContrast extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'color-contrast',
description: 'Background and foreground colors have a sufficient contrast ratio.',
failureDescription: 'Background and foreground colors do not have a ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/definition-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class DefinitionList extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'definition-list',
description: '`<dl>`\'s contain only properly-ordered `<dt>` and `<dd>` groups, `<script>` ' +
'or `<template>` elements.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/dlitem.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class DLItem extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'dlitem',
description: 'Definition list items are wrapped in `<dl>` elements.',
failureDescription: 'Definition list items are not wrapped in `<dl>` elements.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/document-title.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class DocumentTitle extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'document-title',
description: 'Document has a `<title>` element.',
failureDescription: 'Document does not have a `<title>` element.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/duplicate-id.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class DuplicateId extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'duplicate-id',
description: '`[id]` attributes on the page are unique.',
failureDescription: '`[id]` attributes on the page are not unique.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/frame-title.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class FrameTitle extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'frame-title',
description: '`<frame>` or `<iframe>` elements have a title.',
failureDescription: '`<frame>` or `<iframe>` elements do not have a title.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/html-has-lang.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class HTMLHasLang extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'html-has-lang',
description: '`<html>` element has a `[lang]` attribute.',
failureDescription: '`<html>` element does not have a `[lang]` attribute.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/html-lang-valid.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class HTMLLangValid extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'html-lang-valid',
description: '`<html>` element has a valid value for its `[lang]` attribute.',
failureDescription: '`<html>` element does not have a valid value for ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/image-alt.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ImageAlt extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'image-alt',
description: 'Image elements have `[alt]` attributes.',
failureDescription: 'Image elements do not have `[alt]` attributes.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/input-image-alt.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class InputImageAlt extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'input-image-alt',
description: '`<input type="image">` elements have `[alt]` text.',
failureDescription: '`<input type="image">` elements do not have `[alt]` text.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/label.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class Label extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'label',
description: 'Form elements have associated labels.',
failureDescription: 'Form elements do not have associated labels.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/layout-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class LayoutTable extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'layout-table',
description: 'Presentational `<table>` elements avoid using `<th>`, `<caption>` or the ' +
'`[summary]` attribute.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/link-name.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class LinkName extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'link-name',
description: 'Links have a discernible name.',
failureDescription: 'Links do not have a discernable name.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/list.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class List extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'list',
description: 'Lists contain only `<li>` elements and script supporting elements ' +
'(`<script>` and `<template>`).',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/listitem.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ListItem extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'listitem',
description: 'List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements.',
failureDescription: 'List items (`<li>`) are not contained within `<ul>` ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/meta-refresh.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class MetaRefresh extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'meta-refresh',
description: 'The document does not use `<meta http-equiv="refresh">`.',
failureDescription: 'The document uses `<meta http-equiv="refresh">`.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/meta-viewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class MetaViewport extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'meta-viewport',
description: '`[user-scalable="no"]` is not used in the `<meta name="viewport">` ' +
'element and the `[maximum-scale]` attribute is not less than 5.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/object-alt.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ObjectAlt extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'object-alt',
description: '`<object>` elements have `[alt]` text.',
failureDescription: '`<object>` elements do not have `[alt]` text.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/tabindex.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class TabIndex extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'tabindex',
description: 'No element has a `[tabindex]` value greater than 0.',
failureDescription: 'Some elements have a `[tabindex]` value greater than 0.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/td-headers-attr.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class TDHeadersAttr extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'td-headers-attr',
description: 'Cells in a `<table>` element that use the `[headers]` attribute only refer ' +
'to other cells of that same table.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/th-has-data-cells.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class THHasDataCells extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'th-has-data-cells',
description: '`<th>` elements and elements with `[role="columnheader"/"rowheader"]` have ' +
'data cells they describe.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/valid-lang.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class ValidLang extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'valid-lang',
description: '`[lang]` attributes have a valid value.',
failureDescription: '`[lang]` attributes do not have a valid value.',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/video-caption.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class VideoCaption extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'video-caption',
description: '`<video>` elements contain a `<track>` element with `[kind="captions"]`.',
failureDescription: '`<video>` elements do not contain a `<track>` element ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/accessibility/video-description.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class VideoDescription extends AxeAudit {
*/
static get meta() {
return {
category: 'Accessibility',
name: 'video-description',
description: '`<video>` elements contain a `<track>` element with `[kind="description"]`.',
failureDescription: '`<video>` elements do not contain a `<track>` element with ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/audit.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ class Audit {
informative: audit.meta.informative,
manual: audit.meta.manual,
name: audit.meta.name,
category: audit.meta.category,
description: auditDescription,
helpText: audit.meta.helpText,
details: result.details,
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/byte-efficiency/offscreen-images.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ class OffscreenImages extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Images',
name: 'offscreen-images',
description: 'Offscreen images',
informative: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class TotalByteWeight extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Network',
name: 'total-byte-weight',
optimalValue: `< ${this.bytesToKbString(OPTIMAL_VALUE)}`,
description: 'Avoids enormous network payloads',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/byte-efficiency/unused-css-rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class UnusedCSSRules extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'CSS',
name: 'unused-css-rules',
description: 'Unused CSS rules',
informative: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class UnusedJavaScript extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Performance',
name: 'unused-javascript',
description: 'Unused JavaScript',
informative: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class UsesOptimizedImages extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Images',
name: 'uses-optimized-images',
description: 'Optimize images',
informative: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ class ResponsesAreCompressed extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Performance',
name: 'uses-request-compression',
informative: true,
description: 'Enable text compression',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class UsesResponsiveImages extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Images',
name: 'uses-responsive-images',
description: 'Properly size images',
informative: true,
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/byte-efficiency/uses-webp-images.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class UsesWebPImages extends ByteEfficiencyAudit {
*/
static get meta() {
return {
category: 'Images',
name: 'uses-webp-images',
description: 'Serve images as WebP',
informative: true,
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/cache-start-url.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class CacheStartUrl extends Audit {
*/
static get meta() {
return {
category: 'Manifest',
name: 'cache-start-url',
description: 'Cache contains start_url from manifest (alpha)',
failureDescription: 'Cache does not contain start_url from manifest (alpha)',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/consistently-interactive.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ class ConsistentlyInteractiveMetric extends Audit {
*/
static get meta() {
return {
category: 'Performance',
name: 'consistently-interactive',
description: 'Consistently Interactive (beta)',
helpText: 'Consistently Interactive marks the time at which the page is ' +
Expand Down
1 change: 0 additions & 1 deletion lighthouse-core/audits/content-width.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class ContentWidth extends Audit {
*/
static get meta() {
return {
category: 'Mobile Friendly',
name: 'content-width',
description: 'Content is sized correctly for the viewport',
failureDescription: 'Content is not sized correctly for the viewport',
Expand Down
Loading