Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(dependency-graph): add cycle sanity check #3592

Merged
merged 1 commit into from
Oct 19, 2017
Merged

core(dependency-graph): add cycle sanity check #3592

merged 1 commit into from
Oct 19, 2017

Conversation

patrickhulce
Copy link
Collaborator

closes #2703

@paulirish
Copy link
Member

sgtm. i'll let brendan take this.

brendankenny
brendankenny approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@brendankenny brendankenny merged commit 74ae043 into master Oct 19, 2017
@brendankenny brendankenny deleted the predictive_perf__cycles branch October 19, 2017 21:22
@dependencies dependencies bot mentioned this pull request Dec 17, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement FastMode MVP
3 participants
@patrickhulce @paulirish @brendankenny