Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smokehouse): disable multiple shadow root deprecation test #3695

Merged
merged 1 commit into from
Oct 31, 2017
Merged

tests(smokehouse): disable multiple shadow root deprecation test #3695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ if (location.search === '' || params.has('passiveEvents')) {
if (location.search === '' || params.has('deprecations')) {
const div = document.createElement('div');
div.createShadowRoot();
div.createShadowRoot(); // FAIL - multiple shadow v0 roots.
// FAIL(errors-in-console) - multiple shadow v0 roots.
// TODO: disabled until m64 is stable (when moved from deprecation warning to error)
// div.createShadowRoot();
}

})();
5 changes: 3 additions & 2 deletions lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module.exports = [
audits: {
'errors-in-console': {
score: false,
// TODO: should be 5 after m64 (see note in dbw_tester.js)
rawValue: 4,
displayValue: '4',
details: {
Expand Down Expand Up @@ -168,12 +169,12 @@ module.exports = [
score: false,
extendedInfo: {
value: {
length: 4,
length: 3,
},
},
details: {
items: {
length: 4,
length: 3,
},
},
},
Expand Down