Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smokehouse): improve smokehouse failure output #4482

Merged
merged 1 commit into from
Feb 9, 2018
Merged

tests(smokehouse): improve smokehouse failure output #4482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions lighthouse-cli/test/smokehouse/smokehouse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,23 +209,34 @@ function collateResults(actual, expected) {
* @param {{category: string, equal: boolean, diff: ?Object, actual: boolean, expected: boolean}} assertion
*/
function reportAssertion(assertion) {
const _toJSON = RegExp.prototype.toJSON;
// eslint-disable-next-line no-extend-native
RegExp.prototype.toJSON = RegExp.prototype.toString;

if (assertion.equal) {
console.log(` ${log.greenify(log.tick)} ${assertion.category}: ` +
log.greenify(assertion.actual));
} else {
if (assertion.diff) {
const diff = assertion.diff;
let msg = ` ${log.redify(log.cross)} difference at ${diff.path}: `;
msg += log.redify(`found ${diff.actual}, expected ${diff.expected}\n`);

const fullActual = JSON.stringify(assertion.actual, null, 2).replace(/\n/g, '\n ');
msg += log.redify(' full found result: ' + fullActual);
const msg = `
${log.redify(log.cross)} difference at ${log.bold}${diff.path}${log.reset}
expected: ${JSON.stringify(diff.expected)}
found: ${JSON.stringify(diff.actual)}
found result: ${log.redify(fullActual)}
`;
console.log(msg);
} else {
console.log(` ${log.redify(log.cross)} ${assertion.category}: ` +
log.redify(`found ${assertion.actual}, expected ${assertion.expected}`));
console.log(` ${log.redify(log.cross)} ${assertion.category}:
expected: ${JSON.stringify(assertion.expected)}
found: ${JSON.stringify(assertion.actual)}
`);
}
}

// eslint-disable-next-line no-extend-native
RegExp.prototype.toJSON = _toJSON;
}

/**
Expand Down