Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(lantern): move metrics to computed artifacts #4766

Merged
merged 16 commits into from
Mar 30, 2018
Merged

core(lantern): move metrics to computed artifacts #4766

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f7c0324
core(lantern): move metrics to computed artifacts
patrickhulce Mar 14, 2018
43e6ffe
"es8 isn't a real thing" - paulirish
patrickhulce Mar 19, 2018
5f34338
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce Mar 19, 2018
17be96d
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce Mar 20, 2018
be7b1d3
typecheck!
patrickhulce Mar 20, 2018
d4d2b5f
move to lantern- prefix
patrickhulce Mar 20, 2018
0be326d
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce Mar 20, 2018
9d64fa9
remove tern
patrickhulce Mar 20, 2018
6a75bf8
cleanup d.ts file
patrickhulce Mar 20, 2018
413ec5d
feedback
patrickhulce Mar 29, 2018
ad61451
cleanup timeInMs rewrite business
patrickhulce Mar 29, 2018
4c8cdc4
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce Mar 30, 2018
d794222
s/TaskMultiplier/SlowdownMultiplier
patrickhulce Mar 30, 2018
d8296eb
log extension test error
patrickhulce Mar 30, 2018
4694b1f
fix extension gulp
patrickhulce Mar 30, 2018
25e0650
last feedback
patrickhulce Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-cli/printer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function writeFile(filePath, output, outputMode) {
* @param {!LH.Results} results
* @param {string} mode
* @param {string} path
* @return {!Promise<!LH.Results>}
* @return {Promise<LH.Results>}
*/
function write(results, mode, path) {
return new Promise((resolve, reject) => {
Expand Down
8 changes: 4 additions & 4 deletions lighthouse-cli/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function parseChromeFlags(flags = '') {
* Attempts to connect to an instance of Chrome with an open remote-debugging
* port. If none is found, launches a debuggable instance.
* @param {!LH.Flags} flags
* @return {!Promise<!LH.LaunchedChrome>}
* @return {Promise<LH.LaunchedChrome>}
*/
function getDebuggableChrome(flags) {
return ChromeLauncher.launch({
Expand Down Expand Up @@ -98,7 +98,7 @@ function handleError(err) {
* @param {!LH.Results} results
* @param {!Object} artifacts
* @param {!LH.Flags} flags
* @return {!Promise<void>}
* @return {Promise<void>}
*/
function saveResults(results, artifacts, flags) {
const cwd = process.cwd();
Expand Down Expand Up @@ -149,7 +149,7 @@ function saveResults(results, artifacts, flags) {
* @param {string} url
* @param {!LH.Flags} flags
* @param {!LH.Config|undefined} config
* @return {!Promise<!LH.Results|void>}
* @return {Promise<LH.Results|void>}
*/
function runLighthouse(url, flags, config) {
/** @type {!LH.LaunchedChrome} */
Expand Down Expand Up @@ -183,7 +183,7 @@ function runLighthouse(url, flags, config) {
});

/**
* @return {!Promise<{}>}
* @return {Promise<{}>}
*/
function potentiallyKillChrome() {
if (launchedChrome !== undefined) {
Expand Down
13 changes: 9 additions & 4 deletions lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
'use strict';

const Audit = require('../audit');
const PredictivePerf = require('../predictive-perf');
const ConsistentlyInteractive = require('../../gather/computed/metrics/lantern-consistently-interactive'); // eslint-disable-line max-len
const NetworkAnalysis = require('../../gather/computed/network-analysis');
const LoadSimulator = require('../../lib/dependency-graph/simulator/simulator.js');

const KB_IN_BYTES = 1024;
Expand Down Expand Up @@ -120,8 +121,8 @@ class UnusedBytes extends Audit {
});

const savingsOnTTI = Math.max(
PredictivePerf.getLastLongTaskEndTime(simulationBeforeChanges.nodeTiming) -
PredictivePerf.getLastLongTaskEndTime(simulationAfterChanges.nodeTiming),
ConsistentlyInteractive.getLastLongTaskEndTime(simulationBeforeChanges.nodeTiming) -
ConsistentlyInteractive.getLastLongTaskEndTime(simulationAfterChanges.nodeTiming),
0
);

Expand All @@ -135,7 +136,11 @@ class UnusedBytes extends Audit {
* @return {!AuditResult}
*/
static createAuditResult(result, graph) {
const simulatorOptions = PredictivePerf.computeRTTAndServerResponseTime(graph);
const records = [];
graph.traverse(node => node.record && records.push(node.record));
const simulatorOptions = NetworkAnalysis.computeRTTAndServerResponseTime(records);
// TODO: use rtt/throughput from config.settings instead of defaults
delete simulatorOptions.rtt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set to undefined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately that won't have the same effect, gotta love JS key existence vs. undefined biting us left and right 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep an eye on performance then, but hopefully properties on simulatorOptions aren't the bottleneck anyways... :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 🤣 🤣

// TODO: calibrate multipliers, see https://github.com/GoogleChrome/lighthouse/issues/820
Object.assign(simulatorOptions, {cpuSlowdownMultiplier: 1, layoutTaskMultiplier: 1});
const simulator = new LoadSimulator(graph, simulatorOptions);
Expand Down
Loading