Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds content width audit #493

Merged
merged 6 commits into from
Jul 8, 2016
Merged

Adds content width audit #493

merged 6 commits into from
Jul 8, 2016

Conversation

paullewis
Copy link
Contributor

Similar to PSI:

screen shot 2016-07-06 at 1 09 57 pm


class ContentWidth extends Gather {

afterPass(options) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afterPass({driver}) {
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh destructuring.... good shout.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use destructuring. We'd like to maintain compat with node v4 w/ --harmony.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@paulirish paulirish merged commit f9bdc7f into master Jul 8, 2016
@paulirish paulirish deleted the overflowpage branch July 26, 2016 19:34
@brendankenny brendankenny mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants