Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(bootup-time): fix learn more link #4962

Merged
merged 1 commit into from
Apr 13, 2018
Merged

report(bootup-time): fix learn more link #4962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/bootup-time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class BootupTime extends Audit {
scoreDisplayMode: Audit.SCORING_MODES.NUMERIC,
helpText: 'Consider reducing the time spent parsing, compiling, and executing JS. ' +
'You may find delivering smaller JS payloads helps with this. [Learn ' +
'more](https://developers.google.com/web/lighthouse/audits/bootup).',
'more](https://developers.google.com/web/tools/lighthouse/audits/bootup).',
requiredArtifacts: ['traces'],
};
}
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@
"scoreDisplayMode": "numeric",
"name": "bootup-time",
"description": "JavaScript boot-up time",
"helpText": "Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. [Learn more](https://developers.google.com/web/lighthouse/audits/bootup).",
"helpText": "Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/bootup).",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulirish yeah ignore help text is a good call for our golden file assertions :)

"details": {
"type": "table",
"headings": [
Expand Down Expand Up @@ -5403,6 +5403,6 @@
}
},
"timing": {
"total": 904
"total": 877
}
}