core(screenshots): align filmstrip to observed metrics #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS]; | ||
| const metricComputationData = {trace, devtoolsLog, settings: context.settings}; | ||
| const ttci = artifacts.requestConsistentlyInteractive(metricComputationData); | ||
| alternativeMaximumValue = (await ttci.catch(() => ({timing: 0}))).timing; |
There was a problem hiding this comment.
ha, I'm not sure I'm wild about this approach. try/catch is ugly, but this makes it look like it's doing something much more complicated than it is :S
| data: base64Data, | ||
| const speedline = await artifacts.requestSpeedline(trace); | ||
|
|
||
| let alternativeMaximumValue = 0; |
There was a problem hiding this comment.
add a comment why there needs to be an alternativeMaximumValue? (there's a comment below but maybe some variant should be up here so you don't spend too long thinking about it :)
There was a problem hiding this comment.
yeah good call, done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup fix as promised in #4951
(easier with https://github.com/GoogleChrome/lighthouse/pull/4965/files?w=1)