core(render-blocking): address followup feedback #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| requiredArtifacts: ['CSSUsage', 'URL', 'TagsBlockingFirstPaint', 'traces'], | ||
| // This audit also looks at CSSUsage but has a graceful fallback if it failed, so do not mark | ||
| // it as a "requiredArtifact". | ||
| requiredArtifacts: ['URL', 'TagsBlockingFirstPaint', 'traces'], |
There was a problem hiding this comment.
I like this for working around gatherer errors, but won't this be undesirable if doing an --only-categories/audits? The CSSUsage gatherer could be pruned. It won't be a failure but probably not what you want.
Time to introduce a desiredArtifacts field? :D
There was a problem hiding this comment.
This is also true. I have a slight preference for eliminating the failure case in exchange for making the onlyAudits: ['render-blocking-resource'] case a little more forgiving.
I'll add a todo to look into updating after an optionalArtifacts :D
There was a problem hiding this comment.
Just to be clear, no changes then? (except for a TODO)
if so, sgtm :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #4995