Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(scoring): tweak performance weights #5083

Merged
merged 2 commits into from
May 2, 2018
Merged

core(scoring): tweak performance weights #5083

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8849c8e
core(scoring): tweak performance weights
patrickhulce May 1, 2018
7f50748
golden lhr
patrickhulce May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lighthouse-core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,13 @@ module.exports = {
name: 'Performance',
description: 'These encapsulate your web app\'s current performance and opportunities to improve it.',
audits: [
{id: 'first-contentful-paint', weight: 5, group: 'perf-metric'},
{id: 'first-meaningful-paint', weight: 3, group: 'perf-metric'},
{id: 'first-cpu-idle', weight: 5, group: 'perf-metric'},
{id: 'first-contentful-paint', weight: 3, group: 'perf-metric'},
{id: 'first-meaningful-paint', weight: 1, group: 'perf-metric'},
{id: 'speed-index', weight: 4, group: 'perf-metric'},
{id: 'interactive', weight: 5, group: 'perf-metric'},
{id: 'speed-index', weight: 1, group: 'perf-metric'},
{id: 'estimated-input-latency', weight: 1, group: 'perf-metric'},
{id: 'first-cpu-idle', weight: 2, group: 'perf-metric'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbd but why did the order change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh just aligning more with the order presented over there, I have no opinion I can revert

{id: 'estimated-input-latency', weight: 0, group: 'perf-metric'},

{id: 'render-blocking-resources', weight: 0, group: 'perf-hint'},
{id: 'uses-responsive-images', weight: 0, group: 'perf-hint'},
{id: 'offscreen-images', weight: 0, group: 'perf-hint'},
Expand Down