-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: celebrate your all 100's #5455
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
38943d9
report: celebrate your all 100's
paulirish 903fb09
fireworks even if you're testing one category (and it scores 100)
paulirish 934e6da
pause on click per @hwikyounglee
paulirish 0ffc453
driveby: fix exception when scrolling a solocat non-devtools
paulirish 218cadc
fix extra 2px of space under lighthouse svg
paulirish ca6f7ca
make header 11px shorter. same LH size.
paulirish d28370a
dark blue sky for the fireworks
paulirish 02f83e0
Made metadata + product info text white on the header when scrolled d…
exterkamp 1190cce
Delayed start of animation to after gauges animate.
exterkamp 221639a
Merge branch 'master' into fireworks
exterkamp 4234ceb
Merge branch 'master' into fireworks
exterkamp e04d281
Added report-renderer-test for coverage.
exterkamp 3a94450
Merge branch 'master' into fireworks
exterkamp 60a97bf
Add lighthouse beam hue-rotation animation!
exterkamp 7ea2db5
Add beam color test.
exterkamp fa02564
Merge branch 'master' into fireworks
exterkamp 5dad698
Deferring party-lights until later :'(
exterkamp 4a68ab2
Remove party -beam tests.
exterkamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this try/catch any longer.. pretty sure it was resolved somewhere else.. but IIRC it only applied in the single-category case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need it. Even on master it throws errors when scrolling in single category reports. I can split this into another PR if it doesn't belong here, but I think this is still a bug.
master:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just move a few lines inside of a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is on the find itself. This still throws, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i meant to say is.. "what a beautiful try/catch! let's keep it just like it is."