core: remove no-mutation-events audit & js callstack method #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
remove_no_mutation_events
branch
from
5ce0967 to
87905d5
Compare
paulirish
requested changes
Jun 15, 2018
done https://bugs.chromium.org/p/chromium/issues/detail?id=719009 |
paulirish
approved these changes
Jun 15, 2018
pushed? |
patrickhulce
force-pushed
the
remove_no_mutation_events
branch
from
87905d5 to
d08457c
Compare
|
pushed now What were your mutation event listener findings? :) |
|
@brendankenny you were 👍 on this, right? |
brendankenny
requested changes
Jun 15, 2018
the things I can still learn exist 😮 |
paulirish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
no-mutation-eventsaudit is the only audit using a large chunk of heavy/slow gatherer code.If this becomes a priority again after passing our new audit process standards, then we still have this diff to look back on or it can become a Chrome violation to be picked up for free :)
comment from the future (paul in nov 2021): this PR also removes some
captureJSCallUsage()weird stuff . it relied onError.prepareStackTracewhich is a wild lil API. We also found that some websites overwritewindow.Errorwith something and this caused problems: #1194This PR removes all that so those websites can continue to be a menace but we no longer care.