Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): fix spelling error in driver method #5553

Merged
merged 1 commit into from
Jun 25, 2018
Merged

core(driver): fix spelling error in driver method #5553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class Driver {
* @param {string} scriptSource
* @return {Promise<LH.Crdp.Page.AddScriptToEvaluateOnLoadResponse>} Identifier of the added script.
*/
evaluteScriptOnNewDocument(scriptSource) {
evaluateScriptOnNewDocument(scriptSource) {
return this.sendCommand('Page.addScriptToEvaluateOnLoad', {
scriptSource,
});
Expand Down Expand Up @@ -1064,7 +1064,7 @@ class Driver {
* @return {Promise<void>}
*/
async cacheNatives() {
await this.evaluteScriptOnNewDocument(`window.__nativePromise = Promise;
await this.evaluateScriptOnNewDocument(`window.__nativePromise = Promise;
window.__nativeError = Error;`);
}

Expand All @@ -1074,7 +1074,7 @@ class Driver {
*/
async registerPerformanceObserver() {
const scriptStr = `(${pageFunctions.registerPerformanceObserverInPage.toString()})()`;
await this.evaluteScriptOnNewDocument(scriptStr);
await this.evaluateScriptOnNewDocument(scriptStr);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/gather/gatherers/dobetterweb/tags-blocking-first-paint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class TagsBlockingFirstPaint extends Gatherer {
* @param {LH.Gatherer.PassContext} passContext
*/
beforePass(passContext) {
return passContext.driver.evaluteScriptOnNewDocument(`(${installMediaListener.toString()})()`);
return passContext.driver.evaluateScriptOnNewDocument(`(${installMediaListener.toString()})()`);
}

/**
Expand Down