Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(smoke): remove console.timeline() call #5560

Merged
merged 4 commits into from
Jun 26, 2018
Merged

tests(smoke): remove console.timeline() call #5560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9711197
tests(smoke): remove console.timeline() call
patrickhulce Jun 26, 2018
68a8a08
add explicit error assertion
patrickhulce Jun 26, 2018
a63ba3b
6 not 5
patrickhulce Jun 26, 2018
865887a
remove more
patrickhulce Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,6 @@ <h2>Do better web tester page</h2>

// TODO: some deprecated API messages are not currently being logged correctly.
// See: https://crbug.com/680832
try {
MediaStreamTrack.getSources(); // Should eventually FAIL
} catch(e) {}

console.timeline(); // Should eventually FAIL

// FAIL
const xhr = new XMLHttpRequest();
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = [
score: 0,
details: {
items: {
length: '>3',
length: 6,
},
},
},
Expand Down