Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(sentry): lower "could not load stylesheet" sampling to 0.01 #5677

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

wardpeet
Copy link
Collaborator

Summary
We've reached our quote of sentry this month because of this issue. Lowered the sample rate to 0.01

Related Issues/PRs
#5676

@paulirish paulirish added the 3.0 label Jul 17, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though are people keeping an eye on sentry mentally keeping these rates in mind? Seems like it would be easy to miss if only looking at relative count of errors (unless the sentry UI already accounts for this and scales appropriately)

@patrickhulce
Copy link
Collaborator

would be easy to miss if only looking at relative count of errors (unless the sentry UI already accounts for this and scales appropriately)

I wish, this is just our own sampling impl so Sentry has no clue we're seeing these. Built-in sampling of particular errors would be awesome but it directly cuts into their pricing strategy so I don't see it happening 😆

@paulirish paulirish merged commit e94be2c into master Jul 17, 2018
@paulirish paulirish deleted the bug/sample-fonts-warning branch July 17, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants