core(i18n): import psuedo-locale json from TC

[paulirish]

updated

• ar-XB is psuedo right to left
• en-XA is accented

[patrickhulce]

cool cool cool

should we add these locales to the cli-flags + typings + index.js? if not, do we want to import them at all or was this just testing :)

also they seem to use _ while I was using - is there a best practice?

[brendankenny]

also want to update https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/lib/locales/index.js

and should

lighthouse/lighthouse-cli/cli-flags.js

Lines 122 to 125 in e99673b

	.choices('locale', [
	'en-US', // English
	'en-XA', // Accented English, good for testing
	])

be based on Object.keys(require('...../locales/index.js'))?

[paulirish]

also they seem to use _ while I was using - is there a best practice?

found another TC export script that has an option for hyphen rather than underscore. So this is a common thing. :)

Since our build script also prefers hyphen i guess we should go with that..

[paulirish]

running

lighthouse -GA --preset=perf http://example.com --locale=en-XA

I currently get this:

should I address it in this PR?

[patrickhulce]

I currently get this:
should I address it in this PR?

:/ ya the extra locales will be useless if we can't actually generate reports with them

[paulirish]

ready for review.

lighthouse --preset=perf --locale=ar-XB http://example.com/
lighthouse --preset=perf --locale=en-XA http://example.com/

[paulirish]

🏏 🏏

[brendankenny]

LGTM!

[brendankenny]

we should probably convert this file back to assert at some point rather than having a different assertion library just for this file

[patrickhulce]

nooooooooooooo 😢 assert is so sad compared to expect