Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(i18n): reframe the ICU message descriptions with placeholders #5737

Merged
merged 1 commit into from
Jul 27, 2018
Merged

core(i18n): reframe the ICU message descriptions with placeholders #5737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/byte-efficiency/total-byte-weight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const UIStrings = {
'Large network payloads cost users real money and are highly correlated with ' +
'long load times. [Learn ' +
'more](https://developers.google.com/web/tools/lighthouse/audits/network-payloads).',
/** [ICU Syntax] Used to summarize the total byte size of the page and all its network requests */
/** Used to summarize the total byte size of the page and all its network requests. The `{totalBytes}` placeholder will be replaced with the total byte sizes, shown in kilobytes (e.g. 142 KB) */
displayValue: 'Total size was {totalBytes, number, bytes}\xa0KB',
};

Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/time-to-first-byte.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const UIStrings = {
failureTitle: 'Reduce server response times (TTFB)',
description: 'Time To First Byte identifies the time at which your server sends a response.' +
' [Learn more](https://developers.google.com/web/tools/lighthouse/audits/ttfb).',
/** [ICU Syntax] Used to summarize the total Time to First Byte duration for the primary HTML response */
/** Used to summarize the total Time to First Byte duration for the primary HTML response. The `{timeInMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 210 ms) */
displayValue: `Root document took {timeInMs, number, milliseconds}\xa0ms`,
};

Expand Down
6 changes: 3 additions & 3 deletions lighthouse-core/lib/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ const MESSAGE_INSTANCE_ID_REGEX = /(.* \| .*) # (\d+)$/;


const UIStrings = {
/** [ICU Syntax] Used to show the duration in milliseconds that something lasted */
/** Used to show the duration in milliseconds that something lasted. The `{timeInMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 63 ms) */
ms: '{timeInMs, number, milliseconds}\xa0ms',
/** [ICU Syntax] Used to show how many bytes the user could reduce their page by if they implemented the suggestions */
/** Used to show how many bytes the user could reduce their page by if they implemented the suggestions. The `{wastedBytes}` placeholder will be replaced with the number of bytes, shown in kilobytes (e.g. 148 KB) */
displayValueByteSavings: 'Potential savings of {wastedBytes, number, bytes}\xa0KB',
/** [ICU Syntax] Used to show how many milliseconds the user could reduce page load by if they implemented the suggestions */
/** Used to show how many milliseconds the user could reduce page load by if they implemented the suggestions. The `{wastedMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 140 ms) */
displayValueMsSavings: 'Potential savings of {wastedMs, number, milliseconds}\xa0ms',
/** Label for the URL column in data tables, entries will be the URL of a web resource */
columnURL: 'URL',
Expand Down
10 changes: 5 additions & 5 deletions lighthouse-core/lib/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
},
"lighthouse-core/audits/byte-efficiency/total-byte-weight.js | displayValue": {
"message": "Total size was {totalBytes, number, bytes} KB",
"description": "[ICU Syntax] Used to summarize the total byte size of the page and all its network requests"
"description": "Used to summarize the total byte size of the page and all its network requests. The `{totalBytes}` placeholder will be replaced with the total byte sizes, shown in kilobytes (e.g. 142 KB)"
},
"lighthouse-core/audits/byte-efficiency/unminified-css.js | title": {
"message": "Minify CSS"
Expand Down Expand Up @@ -222,7 +222,7 @@
},
"lighthouse-core/audits/time-to-first-byte.js | displayValue": {
"message": "Root document took {timeInMs, number, milliseconds} ms",
"description": "[ICU Syntax] Used to summarize the total Time to First Byte duration for the primary HTML response"
"description": "Used to summarize the total Time to First Byte duration for the primary HTML response. The `{timeInMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 210 ms)"
},
"lighthouse-core/audits/user-timings.js | title": {
"message": "User Timing marks and measures"
Expand Down Expand Up @@ -265,15 +265,15 @@
},
"lighthouse-core/lib/i18n.js | ms": {
"message": "{timeInMs, number, milliseconds} ms",
"description": "[ICU Syntax] Used to show the duration in milliseconds that something lasted"
"description": "Used to show the duration in milliseconds that something lasted. The `{timeInMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 63 ms)"
},
"lighthouse-core/lib/i18n.js | displayValueByteSavings": {
"message": "Potential savings of {wastedBytes, number, bytes} KB",
"description": "[ICU Syntax] Used to show how many bytes the user could reduce their page by if they implemented the suggestions"
"description": "Used to show how many bytes the user could reduce their page by if they implemented the suggestions. The `{wastedBytes}` placeholder will be replaced with the number of bytes, shown in kilobytes (e.g. 148 KB)"
},
"lighthouse-core/lib/i18n.js | displayValueMsSavings": {
"message": "Potential savings of {wastedMs, number, milliseconds} ms",
"description": "[ICU Syntax] Used to show how many milliseconds the user could reduce page load by if they implemented the suggestions"
"description": "Used to show how many milliseconds the user could reduce page load by if they implemented the suggestions. The `{wastedMs}` placeholder will be replaced with the time duration, shown in milliseconds (e.g. 140 ms)"
},
"lighthouse-core/lib/i18n.js | columnURL": {
"message": "URL",
Expand Down