Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(snyk): update snyk snapshot #5890

Closed
wants to merge 1 commit into from
Closed

deps(snyk): update snyk snapshot #5890

wants to merge 1 commit into from

Conversation

snyk-bot
Copy link
Contributor

Why this PR?

a weekly update of the vulnerabilities snapshot for lighthouse

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@aviadatsnyk
Copy link
Contributor

@snyk-bot used to have no issues with cla/google (for example, #5774). Anything changed?

@snyk-bot
Copy link
Contributor Author

I signed it!

@patrickhulce
Copy link
Collaborator

I believe it's based solely on the email address in every commit, did snyk-bot's email address for commits change?

@brendankenny
Copy link
Member

I don't see the snyk-bot's email address in the individual CLAs list, but #5774 did pass before and appears to have used that same email address, so something else changed, maybe?

Did you all recently switch to a corporate CLA? I see "Snyk Ltd" in that list, so I believe the process in https://cla.developers.google.com/about#add-contributors should work to add snyk-bot (if it isn't added and something is just going wrong).

@paulirish
Copy link
Member

@aviadatsnyk see "How do I add authorized contributors for my company?" on https://cla.developers.google.com/about#add-contributors

I suspect that is the fix for this.

If the bot account is already in the group I can email people here to debug further.

thanks!

@paulirish
Copy link
Member

@aviadatsnyk ping. did you get a change to look at the group membership?

@paulirish paulirish closed this Sep 6, 2018
@aviadatsnyk
Copy link
Contributor

sorry for dropping the ball on this one - looking at it now.

@aviadatsnyk
Copy link
Contributor

fixed on our end. #6074

@brendankenny
Copy link
Member

thanks @aviadatsnyk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants