Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: change extension test url from paulirish.com to google.com #6064

Closed
wants to merge 1 commit into from

Conversation

wardpeet
Copy link
Collaborator

Summary
Changin the test url to google.com

Related Issues/PRs
#5798

@wardpeet
Copy link
Collaborator Author

how can we make sure the test actually would fail? As on my chrome it works (chrome 69)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we shouldn't change it?

I don't think we have a hope of automatically catching things as fundamental as that change with a simple smoke test, and paulirish.com is relatively more stable wrt caching/offline/etc than google.com might be in the future.

@wardpeet
Copy link
Collaborator Author

Honestly I don't really care what url we test but I agree that paulirish.com is probably a more stable url and we probably get these edge cases logged by the report button anyway.

@paulirish paulirish closed this Sep 20, 2018
@paulirish paulirish deleted the fix/extension-url branch September 20, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants