options and terminology fixes and docs added to extension code #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
changed the title
brendankenny
changed the title
| const log = require('../../../lighthouse-core/lib/log'); | ||
|
|
||
| const defaultConfigJSON = JSON.stringify(defaultConfig); |
There was a problem hiding this comment.
lets do this stringify down where we parse. too many configs running about :)
brendankenny
force-pushed
the
extensionclean
branch
from
eca593a to
8dbd6fa
Compare
| background.loadSelectedAggregations() | ||
| .then(getAuditsFromSelected) | ||
| .then(selectedAudits => { | ||
| return background.runLighthouse({ |
There was a problem hiding this comment.
@brendankenny why use a return here?
There was a problem hiding this comment.
just a (debatable :) readability improvement. It's often easy to miss that a multiline body on an arrow function is being returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup of extension code, which has grown a little hairy as it has accumulated. Mostly:
s/audits/aggregationsafter Save audit list into storage so it's kept for the next run #595, to reflect that it's aggregation categories being saved and loaded for the options list, not audits themselvesThis PR fixes 2 bugs:
Configconstructor. Amazingly, the browserify polyfill forpath.dirnameparsesnew Set(['array', 'of', 'audit', 'names'])as'.', so this wasn't actually causing any problems.