Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): address bckenny feedback on #6117 #6285

Merged
merged 2 commits into from
Oct 16, 2018
Merged

core(driver): address bckenny feedback on #6117 #6285

merged 2 commits into from
Oct 16, 2018

Conversation

paulirish
Copy link
Member

No description provided.

brendankenny
brendankenny approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulirish paulirish merged commit 72a0932 into master Oct 16, 2018
@paulirish paulirish deleted the bckfeedback branch October 16, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny