Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): stringify protocol error messages #6302

Merged
merged 2 commits into from
Oct 17, 2018
Merged

core(driver): stringify protocol error messages #6302

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33d6666
core(driver): stringify protocol error messages
paulirish Oct 17, 2018
2e46730
.data too
paulirish Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/lib/lh-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class LighthouseError extends Error {
}

// otherwise fallback to building a generic Error
let errMsg = `(${method}): ${protocolError.message}`;
let errMsg = `(${method}): ${JSON.stringify(protocolError.message)}`;
if (protocolError.data) errMsg += ` (${protocolError.data})`;
const error = new Error(`Protocol error ${errMsg}`);
return Object.assign(error, {protocolMethod: method, protocolError: protocolError.message});
Expand Down