Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: lantern script path resolution fix #6380

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
easier if the path is resolved against, cwd instead of relative to scripts directory, the only usage in our codebase of run-once already fully resolves the path anyway.

Related Issues/PRs
#6378

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit e3949e2 into master Oct 24, 2018
@brendankenny brendankenny deleted the lantern_path_fix branch October 24, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants