report: larger vertical margins for audit-group summaries #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
|
Does this go for DevTools too? I guess we're already different enough from the rest of the aesthetic what's a little more spacious layout 😆 |
brendankenny
commented
Nov 29, 2018
| margin-bottom: 0; | ||
| } | ||
|
|
||
| .lh-audit-group__summary { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| padding-right: var(--text-indent); | ||
| margin-bottom: var(--lh-audit-vpadding); | ||
| margin-top: calc(var(--section-padding) * 1.5); | ||
| margin-bottom: var(--section-padding); |
There was a problem hiding this comment.
--section-padding is admittedly somewhat a pick out of a hat, but it mostly matches what's being done here, and it gets the slightly more crowded style for devtools (24/16px by default, 18/12px in devtools)
(plus @paulirish suggested using it for this :)
ha, ninjaed :) It's possible it's still too spread out for devtools, but maybe we can tweak? It was |
paulirish
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6395
Widens the vertical margins around group header summaries to match the specced design (see discussion starting with #6395 (comment)).
Before:
After:
Things are a little spread out for e.g. the a11y groups:
but it's not egregious