core(lantern): drop node id from error message #6774
Conversation
It isn't as an isolated aggregate error message. It's really useful when you're logging other parts of the graph too like I was when working on lantern and can look at the nodes to see which it is, but at that point, could just add back in a log statement. Might be nice to have some extra use of |
| @@ -209,7 +209,7 @@ class BaseNode { | |||
| } | |||
| }); | |||
|
|
|||
| if (!idToNodeMap.has(this.id)) throw new Error(`Cloned graph missing node ${this.id}`); | |||
| if (!idToNodeMap.has(this.id)) throw new Error(`Cloned graph missing node`); | |||
There was a problem hiding this comment.
smallest nit in the world of nits....BACKTICK -> COMMA TO THE TOP since there's no more interpolation
There was a problem hiding this comment.
Oops. I figured that edit would show up as a suggestion. I just changed it for you :)
In LR we collect and report all our errors. This one causes our metrics to get a little funky since it changes every time.
Does this work for you, @patrickhulce.
Also i imagine you want a few URLs that can reproduce this?
b/120845363