Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: stricter LR desktop metric thresholds #6969

Closed
wants to merge 2 commits into from
Closed

core: stricter LR desktop metric thresholds #6969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83e1c86
core: stricter LR desktop metric thresholds
patrickhulce Jan 9, 2019
4c9a039
Update lighthouse-core/config/lr-desktop-config.js
exterkamp Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lighthouse-cli/cli-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ function getFlags(manualArgv) {
// default values
.default('chrome-flags', '')
.default('output', ['html'])
.default('emulated-form-factor', 'mobile')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an erroneous double default that makes it impossible to run lr-desktop-config from the CLI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the cli flag winning over the config setting? Yeah, that seems bad...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does output have the same problem? I don't see any other of these defaults in SharedFlagsSettings

.default('port', 0)
.default('hostname', 'localhost')
.default('enable-error-reporting', undefined) // Undefined so prompted by default
Expand Down
13 changes: 13 additions & 0 deletions lighthouse-core/config/lr-desktop-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ const config = {
// Skip the h2 audit so it doesn't lie to us. See #6539
skipAudits: ['uses-http2'],
},
audits: [
// 75th and 95th percentiles -> median and PODR
// SELECT QUANTILES(renderStart, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000
{path: 'metrics/first-contentful-paint', options: {scorePODR: 800, scoreMedian: 1600}},
{path: 'metrics/first-meaningful-paint', options: {scorePODR: 800, scoreMedian: 1600}},
// 75th and 95th percentiles -> median and PODR
// SELECT QUANTILES(SpeedIndex, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000
{path: 'metrics/speed-index', options: {scorePODR: 1100, scoreMedian: 2300}},
// 75th and 95th percentiles -> median and PODR
// SELECT QUANTILES(fullyLoaded, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000
{path: 'metrics/interactive', options: {scorePODR: 2000, scoreMedian: 4500}},
{path: 'metrics/first-cpu-idle', options: {scorePODR: 2000, scoreMedian: 4500}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooooo good luck desktop sites!

],
};

module.exports = config;