Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 #7024

Merged
merged 2 commits into from
Jan 16, 2019
Merged

4.0.0 #7024

merged 2 commits into from
Jan 16, 2019

Conversation

brendankenny
Copy link
Member

No description provided.

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg.
we should collect our breaking changes (LHR stuff) for the releases page, but this changelog is good for now.

@@ -17,7 +17,7 @@ module.exports = [
score: 0,
details: {
items: {
length: 6,
length: 7,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was ist das?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ein Fehler

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was ist das?

whoops, was testing :)

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the smokehouse deal :)

@@ -1,6 +1,6 @@
{
"name": "__MSG_appName__",
"version": "3.3.0.4100",
"version": "4.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@brendankenny brendankenny merged commit bfa10f1 into master Jan 16, 2019
@brendankenny brendankenny deleted the 4.0 branch January 16, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants