misc(ci): build report and deploy to now.sh on every commit #8194
Conversation
| #!/usr/bin/env node | ||
|
|
||
| /** | ||
| * @license Copyright 2018 Google Inc. All Rights Reserved. |
There was a problem hiding this comment.
| * @license Copyright 2018 Google Inc. All Rights Reserved. | |
| * @license Copyright 2019 Google Inc. All Rights Reserved. |
| const ReportGenerator = require('../../lighthouse-core/report/report-generator'); | ||
| const lhr = require('../../lighthouse-core/test/results/sample_v2.json'); | ||
|
|
||
| console.log('🕒 Generating report for sample_v2.json...'); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.build-for-now.sh
Outdated
| #!/usr/bin/env bash | ||
| set -x | ||
|
|
||
| # manually install this one report dependency. Avoid installing all deps. |
There was a problem hiding this comment.
nit: First letter caps w/punctuation or no punctuation on all comments in this file.
| "version": 2, | ||
| "builds": [ | ||
| { | ||
| "src": ".build-for-now.sh", |
There was a problem hiding this comment.
bummer that you have to both manually specify the script and put it in the root 😆
There was a problem hiding this comment.
Yup. I tried putting it in core/scripts but it then 1) expected a dist in core/scripts/dist and 2) then when it gets published you still also have to navigate some web UI of folder structure.
It was dumb.
| console.log('🕒 Generating report for sample_v2.json...'); | ||
| // @ts-ignore | ||
| const html = ReportGenerator.generateReport(lhr, 'html'); | ||
| const filename = path.resolve(__dirname + '/../../dist/index.html'); |
There was a problem hiding this comment.
is this a magic path for it to upload or just dist is the semanticly correct spot and it does the whole dir?
also why path.resolve if we're just string concating, why not join :)
There was a problem hiding this comment.
dist/ is the default path that is published. https://zeit.co/docs/v2/deployments/official-builders/static-build-now-static-build/#configuring-the-build-output-directory
| set -x | ||
|
|
||
| # manually install this one report dependency. Avoid installing all deps. | ||
| rm package.json |
There was a problem hiding this comment.
heh, just so it doesn't spend time doing all our bs?
There was a problem hiding this comment.
ya. faster builds basically.
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env bash | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -0,0 +1,22 @@ | |||
| #!/usr/bin/env node | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const ReportGenerator = require('../../lighthouse-core/report/report-generator'); |
There was a problem hiding this comment.
| const ReportGenerator = require('../../lighthouse-core/report/report-generator'); | |
| const ReportGenerator = require('../../lighthouse-core/report/report-generator.js'); |
| # Create dist if it's not already there | ||
| mkdir -p dist | ||
|
|
||
| # Generate the report and place as dist/index.html |
There was a problem hiding this comment.
if only we had the -R in GAR
As described in #8159. :)
Jeffy enabled Now for us in this org. Thx!
Each deployment URL is unique. But there are also living URL aliases that represent each branch (including master):
nowjson) islighthouse-git-nowjson.googlechrome.now.shlighthouse-git-<branch name>.googlechrome.now.sh. I don't believe we can change this.lighthouse.googlechrome.now.shThe .sh has to be in the project root for the now builder to be reasonable. Ideally I would have liked it to be in lighthouse-core/scripts, but so it goes.
ref #8159