Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: always run axe last #8216

Merged
merged 2 commits into from
Apr 12, 2019
Merged

core: always run axe last #8216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
237e9ba
core: always run axe last
patrickhulce Apr 12, 2019
32e9813
snapshots
patrickhulce Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,9 +1081,6 @@ Object {
Object {
"path": "chrome-console-messages",
},
Object {
"path": "accessibility",
},
Object {
"path": "anchor-elements",
},
Expand Down Expand Up @@ -1135,6 +1132,9 @@ Object {
Object {
"path": "seo/tap-targets",
},
Object {
"path": "accessibility",
},
],
"networkQuietThresholdMs": 1000,
"passName": "defaultPass",
Expand Down
1 change: 1 addition & 0 deletions lighthouse-cli/test/fixtures/byte-efficiency/tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ <h2>Byte efficiency tester page</h2>
<div class="onscreen" style="width: 30px; height: 30px; background: 25% 50% url(lighthouse-480x320.jpg?sprite);"></div>
<div class="onscreen" style="width: 30px; height: 30px; background: 50% 50% url(lighthouse-480x320.jpg?sprite);"></div>
<div class="onscreen" style="width: 30px; height: 30px; background: 75% 50% url(lighthouse-480x320.jpg?sprite);"></div>
<p style="background: blue;">Add some text here so axe will scroll to the bottom</p>
</div>

<template id="lazily-loaded-image">
Expand Down
1 change: 1 addition & 0 deletions lighthouse-cli/test/smokehouse/byte-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = {
extends: 'lighthouse:full',
settings: {
onlyAudits: [
'accesskeys', // run axe on the page since we've had problems with interactions
'network-requests',
'offscreen-images',
'uses-webp-images',
Expand Down
3 changes: 2 additions & 1 deletion lighthouse-core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ const defaultConfig = {
'viewport-dimensions',
'runtime-exceptions',
'chrome-console-messages',
'accessibility',
'anchor-elements',
'image-elements',
'link-elements',
Expand All @@ -120,6 +119,8 @@ const defaultConfig = {
'seo/embedded-content',
'seo/robots-txt',
'seo/tap-targets',
// Always run axe last because it scrolls the page down to the bottom
'accessibility',
],
},
{
Expand Down