Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(redesign): remove units from table columns #8658

Merged
merged 1 commit into from
Apr 29, 2019
Merged

report(redesign): remove units from table columns #8658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-core/lib/i18n/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,7 +1196,7 @@
"description": "Label for the TTL column in data tables, entries will be the time to live value of the cache header on a web resource"
},
"lighthouse-core/lib/i18n/i18n.js | columnSize": {
"message": "Size (KB)",
"message": "Size",
"description": "Label for the size column in data tables, entries will be the size of a web resource in kilobytes"
},
"lighthouse-core/lib/i18n/i18n.js | columnTimeSpent": {
Expand All @@ -1208,11 +1208,11 @@
"description": "Label for the URL column in data tables, entries will be the URL of a web resource"
},
"lighthouse-core/lib/i18n/i18n.js | columnWastedBytes": {
"message": "Potential Savings (KB)",
"message": "Potential Savings",
"description": "Label for the wasted bytes column in data tables, entries will be the number of kilobytes the user could reduce their page by if they implemented the suggestions"
},
"lighthouse-core/lib/i18n/i18n.js | columnWastedMs": {
"message": "Potential Savings (ms)",
"message": "Potential Savings",
"description": "Label for the wasted bytes column in data tables, entries will be the number of milliseconds the user could reduce page load by if they implemented the suggestions"
},
"lighthouse-core/lib/i18n/i18n.js | displayValueByteSavings": {
Expand Down
6 changes: 3 additions & 3 deletions lighthouse-core/lib/i18n/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ const UIStrings = {
/** Label for the URL column in data tables, entries will be the URL of a web resource */
columnURL: 'URL',
/** Label for the size column in data tables, entries will be the size of a web resource in kilobytes */
columnSize: 'Size (KB)',
columnSize: 'Size',
/** Label for the TTL column in data tables, entries will be the time to live value of the cache header on a web resource */
columnCacheTTL: 'Cache TTL',
/** Label for the wasted bytes column in data tables, entries will be the number of kilobytes the user could reduce their page by if they implemented the suggestions */
columnWastedBytes: 'Potential Savings (KB)',
columnWastedBytes: 'Potential Savings',
/** Label for the wasted bytes column in data tables, entries will be the number of milliseconds the user could reduce page load by if they implemented the suggestions */
columnWastedMs: 'Potential Savings (ms)',
columnWastedMs: 'Potential Savings',
/** Label for the time spent column in data tables, entries will be the number of milliseconds spent during a particular activity */
columnTimeSpent: 'Time Spent',
};
Expand Down
32 changes: 15 additions & 17 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,7 +1928,7 @@
{
"key": "totalBytes",
"itemType": "bytes",
"text": "Size (KB)",
"text": "Size",
"displayUnit": "kb",
"granularity": 1
}
Expand Down Expand Up @@ -2036,7 +2036,7 @@
{
"key": "totalBytes",
"itemType": "bytes",
"text": "Size (KB)"
"text": "Size"
}
],
"items": [
Expand Down Expand Up @@ -2119,12 +2119,12 @@
{
"key": "totalBytes",
"valueType": "bytes",
"label": "Size (KB)"
"label": "Size"
},
{
"key": "wastedMs",
"valueType": "timespanMs",
"label": "Potential Savings (ms)"
"label": "Potential Savings"
}
],
"items": [
Expand Down Expand Up @@ -2193,12 +2193,12 @@
{
"key": "totalBytes",
"valueType": "bytes",
"label": "Size (KB)"
"label": "Size"
},
{
"key": "wastedBytes",
"valueType": "bytes",
"label": "Potential Savings (KB)"
"label": "Potential Savings"
}
],
"items": [
Expand Down Expand Up @@ -2254,12 +2254,12 @@
{
"key": "totalBytes",
"valueType": "bytes",
"label": "Size (KB)"
"label": "Size"
},
{
"key": "wastedBytes",
"valueType": "bytes",
"label": "Potential Savings (KB)"
"label": "Potential Savings"
}
],
"items": [
Expand Down Expand Up @@ -2311,12 +2311,12 @@
{
"key": "totalBytes",
"valueType": "bytes",
"label": "Size (KB)"
"label": "Size"
},
{
"key": "wastedBytes",
"valueType": "bytes",
"label": "Potential Savings (KB)"
"label": "Potential Savings"
}
],
"items": [
Expand Down Expand Up @@ -5139,8 +5139,11 @@
"path": "audits[render-blocking-resources].displayValue"
}
],
"lighthouse-core/lib/i18n/i18n.js | columnWastedMs": [
"audits[render-blocking-resources].details.headings[2].label"
"lighthouse-core/lib/i18n/i18n.js | columnWastedBytes": [
"audits[render-blocking-resources].details.headings[2].label",
"audits[unminified-javascript].details.headings[2].label",
"audits[uses-webp-images].details.headings[3].label",
"audits[uses-text-compression].details.headings[2].label"
],
"lighthouse-core/audits/byte-efficiency/unminified-css.js | title": [
"audits[unminified-css].title"
Expand Down Expand Up @@ -5174,11 +5177,6 @@
"path": "audits[uses-text-compression].displayValue"
}
],
"lighthouse-core/lib/i18n/i18n.js | columnWastedBytes": [
"audits[unminified-javascript].details.headings[2].label",
"audits[uses-webp-images].details.headings[3].label",
"audits[uses-text-compression].details.headings[2].label"
],
"lighthouse-core/audits/byte-efficiency/unused-css-rules.js | title": [
"audits[unused-css-rules].title"
],
Expand Down
20 changes: 10 additions & 10 deletions proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2093,12 +2093,12 @@
},
{
"key": "totalBytes",
"label": "Size (KB)",
"label": "Size",
"valueType": "bytes"
},
{
"key": "wastedMs",
"label": "Potential Savings (ms)",
"label": "Potential Savings",
"valueType": "timespanMs"
}
],
Expand Down Expand Up @@ -2335,7 +2335,7 @@
{
"itemType": "bytes",
"key": "totalBytes",
"text": "Size (KB)"
"text": "Size"
}
],
"items": [
Expand Down Expand Up @@ -2415,12 +2415,12 @@
},
{
"key": "totalBytes",
"label": "Size (KB)",
"label": "Size",
"valueType": "bytes"
},
{
"key": "wastedBytes",
"label": "Potential Savings (KB)",
"label": "Potential Savings",
"valueType": "bytes"
}
],
Expand Down Expand Up @@ -2583,7 +2583,7 @@
"granularity": 1.0,
"itemType": "bytes",
"key": "totalBytes",
"text": "Size (KB)"
"text": "Size"
}
],
"items": [
Expand Down Expand Up @@ -2785,12 +2785,12 @@
},
{
"key": "totalBytes",
"label": "Size (KB)",
"label": "Size",
"valueType": "bytes"
},
{
"key": "wastedBytes",
"label": "Potential Savings (KB)",
"label": "Potential Savings",
"valueType": "bytes"
}
],
Expand Down Expand Up @@ -2832,12 +2832,12 @@
},
{
"key": "totalBytes",
"label": "Size (KB)",
"label": "Size",
"valueType": "bytes"
},
{
"key": "wastedBytes",
"label": "Potential Savings (KB)",
"label": "Potential Savings",
"valueType": "bytes"
}
],
Expand Down