Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: rename release scripts properly #8751

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
As @brendankenny and @hoten pointed out the release scripts didn't get renamed. I must've messed something up with git mv because all the references got updated but not the files themselves.

Sorry for the noise!

Related Issues/PRs
#8387

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to drop the second release, so it's just release/clean-pristine.sh, release/prepare-commit.sh, etc?

@connorjclark
Copy link
Collaborator

connorjclark commented Apr 30, 2019

image
:)

EDIT: oh. nvm.

@patrickhulce
Copy link
Collaborator Author

is it possible to drop the second release, so it's just release/clean-pristine.sh, release/prepare-commit.sh, etc?

done!

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit ad1e2ca into master Apr 30, 2019
@brendankenny brendankenny deleted the rename_release_scripts branch April 30, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants