Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(smoke): re-enable dialog prompt #8894

Merged
merged 4 commits into from
May 28, 2019
Merged

tests(smoke): re-enable dialog prompt #8894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96d81a5
smoke: re-enable dialog prompt
connorjclark May 7, 2019
bc024c8
remove comment
connorjclark May 7, 2019
c6d0e63
empty commit to trigger CI
connorjclark May 10, 2019
22d214c
Update lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
paulirish May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@ <h2>Do better web tester page</h2>
https://github.com/GoogleChrome/lighthouse/issues/1194 -->
<script>window.Error = function(error) { this.stack = 'stacktrace'; };</script>

<!--The javascriptDialogOpening test is disabled as we hit a platform bug frequently on travis-->
<!--<script>window.confirm('Is DBW Mega Tester the best site?')</script>-->
<!-- Does the automatic dialog suppression `driver.dismissJavaScriptDialogs()` work? -->
<script>window.confirm('Is DBW Mega Tester the best site?')</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment as to the purpose of this line

paulirish marked this conversation as resolved.
Show resolved Hide resolved

<script>
function stampTemplate(id, location) {
Expand Down
6 changes: 3 additions & 3 deletions lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,12 @@ module.exports = [
},
'dom-size': {
score: 1,
numericValue: 34,
numericValue: 35,
details: {
items: [
{statistic: 'Total DOM Elements', value: '34'},
{statistic: 'Total DOM Elements', value: '35'},
{statistic: 'Maximum DOM Depth', value: '3'},
{statistic: 'Maximum Child Elements', value: '32'},
{statistic: 'Maximum Child Elements', value: '33'},
],
},
},
Expand Down