GoogleChrome · paulirish · Sep 18, 2019 · May 16, 2019 · May 17, 2019 · May 17, 2019
diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
@@ -1144,6 +1144,9 @@ Object {
         Object {
           "path": "script-elements",
         },
+        Object {
+          "path": "iframe-elements",
+        },
         Object {
           "path": "dobetterweb/appcache",
         },

diff --git a/lighthouse-cli/test/fixtures/online-only.html b/lighthouse-cli/test/fixtures/online-only.html
@@ -4,5 +4,6 @@
     There was nothing special about this site,
     nothing was left to be seen,
     not even a kite.
+    <iframe id="inner-iframe"></iframe>
   </body>
 </html>
diff --git a/lighthouse-cli/test/fixtures/oopif.html b/lighthouse-cli/test/fixtures/oopif.html
@@ -1,10 +1,8 @@
 <!DOCTYPE html>
 <html>
-  <head>
-    <title>Where is my iframe?</title>
-  </head>
   <body>
     <h1>Hello frames</h1>
-    <iframe name="oopif" src="https://www.paulirish.com/2012/why-moving-elements-with-translate-is-better-than-posabs-topleft/" style="width: 100vw; height: 100vh;"></iframe>
+    <iframe id="oopif" name="oopif" src="https://www.paulirish.com/2012/why-moving-elements-with-translate-is-better-than-posabs-topleft/" style="width: 100vw; height: 110vh;"></iframe>
+    <iframe id="outer-iframe" src="http://localhost:10200/online-only.html" style="position: fixed"></iframe>
   </body>
-</html>
+</html>
diff --git a/lighthouse-cli/test/smokehouse/oopif-config.js b/lighthouse-cli/test/smokehouse/oopif-config.js
@@ -10,9 +10,4 @@
  */
 module.exports = {
   extends: 'lighthouse:default',
-  settings: {
-    onlyAudits: [
-      'network-requests',
-    ],
-  },
 };
diff --git a/lighthouse-cli/test/smokehouse/oopif-expectations.js b/lighthouse-cli/test/smokehouse/oopif-expectations.js
@@ -27,5 +27,48 @@ module.exports = [
         },
       },
     },
+    artifacts: {
+      IFrameElements: [
+        {
+          id: 'oopif',
+          src: 'https://www.paulirish.com/2012/why-moving-elements-with-translate-is-better-than-posabs-topleft/',
+          clientRect: {
+            width: '>0',
+            height: '>0',
+          },
+          isPositionFixed: false,
+        },
+        {
+          id: 'outer-iframe',
+          src: 'http://localhost:10200/online-only.html',
+          clientRect: {
+            width: '>0',
+            height: '>0',
+          },
+          isPositionFixed: true,
+          frame: {
+            name: 'outer-iframe',
+            url: 'http://localhost:10200/online-only.html',
+            securityOrigin: 'http://localhost:10200',
+            mimeType: 'text/html',
+          },
+        },
+        {
+          id: 'inner-iframe',
+          src: '',
+          clientRect: {
+            width: '>0',
+            height: '>0',
+          },
+          isPositionFixed: false,
+          frame: {
+            name: 'inner-iframe',
+            url: 'about:blank',
+            securityOrigin: '://',
+            mimeType: 'text/html',
+          },
+        },
+      ],
+    },
   },
 ];
diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js
@@ -126,6 +126,7 @@ const defaultConfig = {
       'link-elements',
       'meta-elements',
       'script-elements',
+      'iframe-elements',
       'dobetterweb/appcache',
       'dobetterweb/doctype',
       'dobetterweb/domstats',

diff --git a/lighthouse-core/gather/gatherers/iframe-elements.js b/lighthouse-core/gather/gatherers/iframe-elements.js
@@ -0,0 +1,80 @@
+/**
+ * @license Copyright 2019 Google Inc. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+'use strict';
+
+const Gatherer = require('./gatherer.js');
+const pageFunctions = require('../../lib/page-functions.js');
+
+/* eslint-env browser, node */
+
+/**
+ * @return {LH.Artifacts['IFrameElements']}
+ */
+/* istanbul ignore next */
+function collectIFrameElements() {
+  // @ts-ignore - put into scope via stringification
+  const iFrameElements = getElementsInDocument('iframe'); // eslint-disable-line no-undef
+  return iFrameElements.map(/** @param {HTMLIFrameElement} node */ (node) => {
+    const clientRect = node.getBoundingClientRect();
+    const {top, bottom, left, right, width, height} = clientRect;
+    return {
+      id: node.id,
+      src: node.src,
+      clientRect: {top, bottom, left, right, width, height},
+      // @ts-ignore - put into scope via stringification
+      isPositionFixed: isPositionFixed(node), // eslint-disable-line no-undef
+    };
+  });
+}
+
+class IFrameElements extends Gatherer {
+  /**
+   * @param {LH.Gatherer.PassContext} passContext
+   * @return {Promise<LH.Artifacts['IFrameElements']>}
+   * @override
+   */
+  async afterPass(passContext) {
+    const driver = passContext.driver;
+
+    const {frameTree} = await driver.sendCommand('Page.getFrameTree');
+    let toVisit = [frameTree];
+    /** @type {Map<string | undefined, LH.Crdp.Page.Frame | undefined>} */
+    const framesByDomId = new Map();
+
+    while (toVisit.length) {
+      const frameTree = toVisit.shift();
+      // Should never be undefined, but needed for tsc.
+      if (!frameTree) continue;
+      if (framesByDomId.has(frameTree.frame.name)) {
+        // DOM ID collision, mark as undefined.
+        framesByDomId.set(frameTree.frame.name, undefined);
+      } else {
+        framesByDomId.set(frameTree.frame.name, frameTree.frame);
+      }
+
+      // Add children to queue.
+      if (frameTree.childFrames) {
+        toVisit = toVisit.concat(frameTree.childFrames);
+      }
+    }
+
+    const expression = `(() => {
+      ${pageFunctions.getOuterHTMLSnippetString};
+      ${pageFunctions.getElementsInDocumentString};
+      ${pageFunctions.isPositionFixedString};
+      return (${collectIFrameElements})();
+    })()`;
+
+    /** @type {LH.Artifacts['IFrameElements']} */
+    const iframeElements = await driver.evaluateAsync(expression, {useIsolation: true});
+    for (const el of iframeElements) {
+      el.frame = framesByDomId.get(el.id);
+    }
+    return iframeElements;
+  }
+}
+
+module.exports = IFrameElements;
diff --git a/lighthouse-core/lib/page-functions.js b/lighthouse-core/lib/page-functions.js
@@ -98,6 +98,13 @@ function getElementsInDocument(selector) {
       if (el.shadowRoot) {
         _findAllElements(el.shadowRoot.querySelectorAll('*'));
       }
+      // If the element has a contentWindow (IFrame), dig deeper.
+      // Try/Catch needed in case of cross-origin frame.
+      try {
+        if (el.contentWindow) {
+          _findAllElements(el.contentWindow.document.querySelectorAll('*'));
+        }
+      } catch (e) {}
     }
   };
   _findAllElements(document.querySelectorAll('*'));
@@ -225,6 +232,44 @@ function getNodeSelector(node) {
   return parts.join(' > ');
 }
 
+/**
+ * This function checks if an element or an ancestor of an element is `position:fixed`.
+ * In addition we ensure that the element is capable of behaving as a `position:fixed`
+ * element, checking that it lives within a scrollable ancestor.
+ * @param {HTMLElement} element
+ * @return {boolean}
+ */
+/* istanbul ignore next */
+function isPositionFixed(element) {
+  /**
+   * @param {HTMLElement} element
+   * @param {string} attr
+   * @return {string}
+   */
+  function getStyleAttrValue(element, attr) {
+    // Check style before computedStyle as computedStyle is expensive.
+    return element.style[attr] || window.getComputedStyle(element)[attr];
+  }
+
+  // Position fixed/sticky has no effect in case when document does not scroll.
+  const htmlEl = document.querySelector('html');
+  if (htmlEl.scrollHeight <= htmlEl.clientHeight ||
+      !['scroll', 'auto', 'visible'].includes(getStyleAttrValue(htmlEl, 'overflowY'))) {
+    return false;
+  }
+
+  let currentEl = element;
+  while (currentEl) {
+    const position = getStyleAttrValue(currentEl, 'position');
+    // Only truly fixed if an ancestor is scrollable.
+    if ((position === 'fixed' || position === 'sticky')) {
+      return true;
+    }
+    currentEl = currentEl.parentElement;
+  }
+  return false;
+}
+
 /**
  * Generate a human-readable label for the given element, based on end-user facing
  * strings like the innerText or alt attribute.
@@ -280,4 +325,5 @@ module.exports = {
   getNodeSelector: getNodeSelector,
   getNodeLabel: getNodeLabel,
   getNodeLabelString: getNodeLabel.toString(),
+  isPositionFixedString: isPositionFixed.toString(),
 };
diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts
@@ -61,6 +61,8 @@ declare global {
     export interface PublicGathererArtifacts {
       /** Console deprecation and intervention warnings logged by Chrome during page load. */
       ConsoleMessages: Crdp.Log.EntryAddedEvent[];
+      /** All the iframe elements in the page.*/
+      IFrameElements: Artifacts.IFrameElement[];
       /** Information on size and loading for all the images in the page. Natural size information for `picture` and CSS images is only available if the image was one of the largest 50 images. */
       ImageElements: Artifacts.ImageElement[];
       /** All the link elements on the page or equivalently declared in `Link` headers. @see https://html.spec.whatwg.org/multipage/links.html */
@@ -182,6 +184,26 @@ declare global {
         params: {name: string; value: string}[];
       }
 
+      export interface IFrameElement {
+        /** The `id` attribute of the iframe. */
+        id: string,
+        /** The `src` attribute of the iframe. */
+        src: string,
+        /** The iframe's ClientRect. @see https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect */
+        clientRect: {
+          top: number;
+          bottom: number;
+          left: number;
+          right: number;
+          width: number;
+          height: number;
+        },
+        /** If the iframe or an ancestor of the iframe is fixed in position. */
+        isPositionFixed: boolean,
+        /** The Frame of the iframe, undefined if cross-origin. @see https://chromedevtools.github.io/devtools-protocol/tot/Page#type-Frame */
+        frame?: Crdp.Page.Frame,
+      }
+
       /** @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#Attributes */
       export interface LinkElement {
         /** The `rel` attribute of the link, normalized to lower case. @see https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types */