Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(logging): change log messages for gathering and trace retrieval #9029

Merged
merged 1 commit into from
May 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/throttling.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ comcast --latency=150 --target-bw=1638
# Run Lighthouse with its own throttling disabled
lighthouse --throttling.requestLatencyMs=0 --throttling.downloadThroughputKbps=0 --throttling.uploadThroughputKbps=0 # ...

# Disable the traffic throttling once you see "Retrieving trace"
# Disable the traffic throttling once you see "Gathering trace"
comcast --stop
```
10 changes: 5 additions & 5 deletions lighthouse-core/gather/gather-runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,14 @@ class GatherRunner {

let trace;
if (passConfig.recordTrace) {
const status = {msg: 'Retrieving trace', id: `lh:gather:getTrace`};
const status = {msg: 'Gathering trace', id: `lh:gather:getTrace`};
log.time(status);
trace = await driver.endTrace();
log.timeEnd(status);
}

const status = {
msg: 'Retrieving devtoolsLog & network records',
msg: 'Gathering devtoolsLog & network records',
id: `lh:gather:getDevtoolsLog`,
};
log.time(status);
Expand Down Expand Up @@ -265,7 +265,7 @@ class GatherRunner {
// Abuse the passContext to pass through gatherer options
passContext.options = gathererDefn.options || {};
const status = {
msg: `Retrieving setup: ${gatherer.name}`,
msg: `Gathering setup: ${gatherer.name}`,
id: `lh:gather:beforePass:${gatherer.name}`,
};
log.time(status, 'verbose');
Expand Down Expand Up @@ -295,7 +295,7 @@ class GatherRunner {
// Abuse the passContext to pass through gatherer options
passContext.options = gathererDefn.options || {};
const status = {
msg: `Retrieving in-page: ${gatherer.name}`,
msg: `Gathering in-page: ${gatherer.name}`,
id: `lh:gather:pass:${gatherer.name}`,
};
log.time(status);
Expand Down Expand Up @@ -327,7 +327,7 @@ class GatherRunner {
for (const gathererDefn of gatherers) {
const gatherer = gathererDefn.instance;
const status = {
msg: `Retrieving: ${gatherer.name}`,
msg: `Gathering: ${gatherer.name}`,
id: `lh:gather:afterPass:${gatherer.name}`,
};
log.time(status);
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ class Runner {
static async _runAudit(auditDefn, artifacts, sharedAuditContext) {
const audit = auditDefn.implementation;
const status = {
msg: `Evaluating: ${i18n.getFormatted(audit.meta.title, 'en-US')}`,
msg: `Auditing: ${i18n.getFormatted(audit.meta.title, 'en-US')}`,
id: `lh:audit:${audit.meta.id}`,
};
log.time(status);
Expand Down