Code

i18n: placeholders#9114

Code

Merged

brendankenny merged 77 commits intomasterGoogleChrome/lighthouse:masterfrom placeholdersGoogleChrome/lighthouse:placeholdersCopy head branch name to clipboardJul 24, 2019

+2,812-2,167

Commits

Commits on Jun 3, 2019

• basic format

  exterkamp

  committed
  656acce

  Copy full SHA for 656acce

Commits on Jun 4, 2019

• Basic placeholder syntax.

  exterkamp

  committed
  fc762a5

  Copy full SHA for fc762a5

• minor corrections

  exterkamp

  committed
  d1cdeab

  Copy full SHA for d1cdeab

• iterating

  exterkamp

  committed
  74e11c1

  Copy full SHA for 74e11c1

• Added ICU plural and ICU select examples.

  exterkamp

  committed
  981e028

  Copy full SHA for 981e028

• Gender example has replacement AND ICU.

  exterkamp

  committed
  6d2dd5d

  Copy full SHA for 6d2dd5d

• less stutter syntax

  exterkamp

  committed
  f22ee1b

  Copy full SHA for f22ee1b

• docs

  exterkamp

  committed
  c66c0c6

  Copy full SHA for c66c0c6

Commits on Jun 12, 2019

• Updated README.

  exterkamp

  committed
  70a5a07

  Copy full SHA for 70a5a07

Commits on Jul 3, 2019

• correct-strings

  exterkamp

  committed
  a7fc83a

  Copy full SHA for a7fc83a

• updated i18n.js

  exterkamp

  committed
  0de5485

  Copy full SHA for 0de5485

• Merge branch 'master' into placeholders

  exterkamp

  committed
  f8650eb

  Copy full SHA for f8650eb

• remove unused from correct-strings

  exterkamp

  committed
  37dc2ae

  Copy full SHA for 37dc2ae

• exported correct-strings to be reused to import. ts first pass on collect & correct.

  exterkamp

  committed
  58c7ded

  Copy full SHA for 58c7ded

• first pass at new UIStrings format.

  exterkamp

  committed
  ad01bdd

  Copy full SHA for ad01bdd

Commits on Jul 4, 2019

• new jsdoc format for comments + _very_ basic parsing.

  exterkamp

  committed
  4182889

  Copy full SHA for 4182889

Commits on Jul 5, 2019

• Better parsing, filled out lh-error descriptions.

  exterkamp

  committed
  8b0f8ea

  Copy full SHA for 8b0f8ea

Commits on Jul 7, 2019

• Fixed tests, made unminified-css and doc-title back to normal.

  exterkamp

  committed
  ddf8171

  Copy full SHA for ddf8171

• Updating readme for i18n.

  exterkamp

  committed
  705ffb6

  Copy full SHA for 705ffb6

Commits on Jul 8, 2019

• More readme updates.

  exterkamp

  committed
  902c2f7

  Copy full SHA for 902c2f7

• Move collect code into seperate util file for testing, and the tests for it

  exterkamp

  committed
  4507138

  Copy full SHA for 4507138

• Add placeholder baking tests.

  exterkamp

  committed
  29e29df

  Copy full SHA for 29e29df

• readme updates

  exterkamp

  committed
  393beb6

  Copy full SHA for 393beb6

• More readme details.

  exterkamp

  committed
  799084c

  Copy full SHA for 799084c

• Added test for ICU with examples, fixed audits that violated this.

  exterkamp

  committed
  86e1593

  Copy full SHA for 86e1593

Commits on Jul 9, 2019

• Patrick foodback

  exterkamp

  committed
  6160402

  Copy full SHA for 6160402

• ICU select & ordinal readme examples. made runtime example more accurate.

  exterkamp

  committed
  02e8977

  Copy full SHA for 02e8977

• collection-util docstrings

  exterkamp

  committed
  f5083b8

  Copy full SHA for f5083b8

• remove old console log

  exterkamp

  committed
  5aca05a

  Copy full SHA for 5aca05a

• update assert on strings to new en-US

  exterkamp

  committed
  ee3e235

  Copy full SHA for ee3e235

• polish

  exterkamp

  committed
  6b8297d

  Copy full SHA for 6b8297d

• refactoring conversion method, testing conversion to follow.

  exterkamp

  committed
  77fcd92

  Copy full SHA for 77fcd92

Commits on Jul 10, 2019

• brendan readme foodback.

  exterkamp

  committed
  7252f3d

  Copy full SHA for 7252f3d

• check for empty descriptions

  exterkamp

  committed
  d4dd3ac

  Copy full SHA for d4dd3ac

Commits on Jul 11, 2019

• Use UIString as primary fallback, since it is just en. Update fallback msg name to be more clear.

  exterkamp

  committed
  996ee5c

  Copy full SHA for 996ee5c

• Untrack pre-locales.

  exterkamp

  committed
  4ff414a

  Copy full SHA for 4ff414a

• reorganized collect and correct

  exterkamp

  committed
  588f574

  Copy full SHA for 588f574

• fixup collect-string output

  paulirish

  committed
  2b17130

  Copy full SHA for 2b17130

Commits on Jul 12, 2019

• Paul foodback. Readme updates, updated yarn cmds, updated ctc naming part 1, updated baking script. en-XL has WP strings now.

  exterkamp

  committed
  570a6cc

  Copy full SHA for 570a6cc

• Wording of CTC and LHL in readme and docstrings. Removed mkdirp. Added .ctc.json to yarn clean.

  exterkamp

  committed
  dcc7cc7

  Copy full SHA for dcc7cc7

• rip my hopes and dreams, thanks linter.

  exterkamp

  committed
  7743cda

  Copy full SHA for 7743cda

• polish to package and to collect-strings

  exterkamp

  committed
  ce01c75

  Copy full SHA for ce01c75

• better examples!

  exterkamp

  committed
  dea280a

  Copy full SHA for dea280a

Commits on Jul 15, 2019

• correct some complex ICU, add backticks.

  exterkamp

  committed
  7f89ccf

  Copy full SHA for 7f89ccf

• Merge branch 'master' into placeholders

  exterkamp

  committed
  cf42496

  Copy full SHA for cf42496

• Update 'yarn update:sample-json' and json itself

  exterkamp

  committed
  d156737

  Copy full SHA for d156737

• Handle the TODOs in readme.

  exterkamp

  committed
  89410f8

  Copy full SHA for 89410f8

• Added @Meanings for all duplicated strings.

  exterkamp

  committed
  ea3616b

  Copy full SHA for ea3616b

• update sample json

  exterkamp

  committed
  3d40437

  Copy full SHA for 3d40437

Commits on Jul 16, 2019

• remove from UIStrings, add autofilled meanings + warning log.

  exterkamp

  committed
  bc2b8f3

  Copy full SHA for bc2b8f3

• Some comments

  exterkamp

  committed
  92cafeb

  Copy full SHA for 92cafeb

• added TODO to collect-strings

  exterkamp

  committed
  3d746d6

  Copy full SHA for 3d746d6

Commits on Jul 17, 2019

• Merge branch 'master' into placeholders

  exterkamp

  committed
  5ad0dff

  Copy full SHA for 5ad0dff

• Paul foodback.

  exterkamp

  committed
  c2e4ce5

  Copy full SHA for c2e4ce5

Commits on Jul 18, 2019

• Brendan baking foodback part 1.

  exterkamp

  committed
  5dd3e07

  Copy full SHA for 5dd3e07

• update bakery, and tests. Remove space from yarn clean.

  exterkamp

  committed
  6eef366

  Copy full SHA for 6eef366

• lint

  exterkamp

  committed
  a35a45e

  Copy full SHA for a35a45e

• foodback round 2, renaming party.

  exterkamp

  committed
  13d0f02

  Copy full SHA for 13d0f02

• Last part of feedback

  exterkamp

  committed
  b34ef95

  Copy full SHA for b34ef95

• windows compat collect-strings handled in appropriate PR.

  exterkamp

  committed
  48283f4

  Copy full SHA for 48283f4

Commits on Jul 19, 2019

• Brendan foodback part 2.

  exterkamp

  committed
  95527d5

  Copy full SHA for 95527d5

• How'd that var get there.

  exterkamp

  committed
  327c7db

  Copy full SHA for 327c7db

Commits on Jul 21, 2019

• Brendan feedback v3

  exterkamp

  committed
  b006cf7

  Copy full SHA for b006cf7

Commits on Jul 22, 2019

• added comment to example fallback.

  exterkamp

  committed
  51cbb78

  Copy full SHA for 51cbb78

• Merge branch 'master' into placeholders

  exterkamp

  committed
  37be64c

  Copy full SHA for 37be64c

• complex ICU -> custom-formatted ICU

  exterkamp

  committed
  d2a8326

  Copy full SHA for d2a8326

• reorg example logic to directIcu replacement.

  exterkamp

  committed
  be426b8

  Copy full SHA for be426b8

• stop empty plcaeholders from being added to every message. Stricter check to prevent regression.

  exterkamp

  committed
  125cb1d

  Copy full SHA for 125cb1d

• updated columnName description

  exterkamp

  committed
  b95b96b

  Copy full SHA for b95b96b

• actually can't assert that in the tests. The undefined part is done after :(

  exterkamp

  committed
  90efcff

  Copy full SHA for 90efcff

Commits on Jul 23, 2019

• @example {example} varName

  exterkamp

  committed
  6e6ef24

  Copy full SHA for 6e6ef24

• whoops. console log left in

  exterkamp

  committed
  6a9ef28

  Copy full SHA for 6a9ef28

• brendan feedback

  exterkamp

  committed
  7762381

  Copy full SHA for 7762381

Commits on Jul 24, 2019

• Merge branch 'master' into placeholders

  exterkamp

  committed
  6c19a17

  Copy full SHA for 6c19a17

• Add sanity check for ctc files

  exterkamp

  committed
  be34f7e

  Copy full SHA for be34f7e

• I feel like my linter is turned off

  exterkamp

  committed
  23a68d5

  Copy full SHA for 23a68d5

• Merge branch 'master' into placeholders

  exterkamp

  committed
  3685dd6

  Copy full SHA for 3685dd6