Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: correct audit titles that should not be capitalized #9419

Merged
merged 8 commits into from
Oct 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/critical-request-chains.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const ComputedChains = require('../computed/critical-request-chains.js');

const UIStrings = {
/** Imperative title of a Lighthouse audit that tells the user to reduce the depth of critical network requests to enhance initial load of a page. Critical request chains are series of dependent network requests that are important for page rendering. For example, here's a 4-request-deep chain: The biglogo.jpg image is required, but is requested via the styles.css style code, which is requested by the initialize.js javascript, which is requested by the page's HTML. This is displayed in a list of audit titles that Lighthouse generates. */
title: 'Minimize Critical Requests Depth',
title: 'Avoid chaining critical requests',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah this is an improvement in clarity

/** Description of a Lighthouse audit that tells the user *why* they should reduce the depth of critical network requests to enhance initial load of a page . This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
description: 'The Critical Request Chains below show you what resources are ' +
'loaded with a high priority. Consider reducing ' +
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/third-party-summary.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const MainThreadTasks = require('../computed/main-thread-tasks.js');

const UIStrings = {
/** Title of a diagnostic audit that provides details about the code on a web page that the user doesn't control (referred to as "third-party code"). This descriptive title is shown to users when the amount is acceptable and no user action is required. */
title: 'Third-Party usage',
title: 'Minimize third-party usage',
/** Title of a diagnostic audit that provides details about the code on a web page that the user doesn't control (referred to as "third-party code"). This imperative title is shown to users when there is a significant amount of page execution time caused by third-party code that should be reduced. */
failureTitle: 'Reduce the impact of third-party code',
/** Description of a Lighthouse audit that identifies the code on the page that the user doesn't control. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/lib/i18n/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@
"message": "{itemCount, plural,\n =1 {1 chain found}\n other {# chains found}\n }"
},
"lighthouse-core/audits/critical-request-chains.js | title": {
"message": "Minimize Critical Requests Depth"
"message": "Avoid chaining critical requests"
},
"lighthouse-core/audits/deprecations.js | columnDeprecate": {
"message": "Deprecation / Warning"
Expand Down Expand Up @@ -1089,7 +1089,7 @@
"message": "Reduce the impact of third-party code"
},
"lighthouse-core/audits/third-party-summary.js | title": {
"message": "Third-Party usage"
"message": "Minimize third-party usage"
},
"lighthouse-core/audits/time-to-first-byte.js | description": {
"message": "Time To First Byte identifies the time at which your server sends a response. [Learn more](https://web.dev/time-to-first-byte)."
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/lib/i18n/locales/en-XL.json
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@
"message": "{itemCount, plural,\n =1 {1 ĉh́âín̂ f́ôún̂d́}\n other {# ĉh́âín̂ś f̂óûńd̂}\n }"
},
"lighthouse-core/audits/critical-request-chains.js | title": {
"message": "M̂ín̂ím̂íẑé Ĉŕît́îćâĺ R̂éq̂úêśt̂ś D̂ép̂t́ĥ"
"message": "Âv́ôíd̂ ćĥáîńîńĝ ćr̂ít̂íĉál̂ ŕêq́ûéŝt́ŝ"
},
"lighthouse-core/audits/deprecations.js | columnDeprecate": {
"message": "D̂ép̂ŕêćât́îón̂ / Ẃâŕn̂ín̂ǵ"
Expand Down Expand Up @@ -1089,7 +1089,7 @@
"message": "R̂éd̂úĉé t̂h́ê ím̂ṕâćt̂ óf̂ t́ĥír̂d́-p̂ár̂t́ŷ ćôd́ê"
},
"lighthouse-core/audits/third-party-summary.js | title": {
"message": "T̂h́îŕd̂-Ṕâŕt̂ý ûśâǵê"
"message": "M̂ín̂ím̂íẑé t̂h́îŕd̂-ṕâŕt̂ý ûśâǵê"
},
"lighthouse-core/audits/time-to-first-byte.js | description": {
"message": "T̂ím̂é T̂ó F̂ír̂śt̂ B́ŷt́ê íd̂én̂t́îf́îéŝ t́ĥé t̂ím̂é ât́ ŵh́îćĥ ýôúr̂ śêŕv̂ér̂ śêńd̂ś â ŕêśp̂ón̂śê. [Ĺêár̂ń m̂ór̂é](https://web.dev/time-to-first-byte)."
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@
},
"critical-request-chains": {
"id": "critical-request-chains",
"title": "Minimize Critical Requests Depth",
"title": "Avoid chaining critical requests",
"description": "The Critical Request Chains below show you what resources are loaded with a high priority. Consider reducing the length of chains, reducing the download size of resources, or deferring the download of unnecessary resources to improve page load. [Learn more](https://web.dev/critical-request-chains).",
"score": null,
"scoreDisplayMode": "informative",
Expand Down Expand Up @@ -1484,7 +1484,7 @@
},
"third-party-summary": {
"id": "third-party-summary",
"title": "Third-Party usage",
"title": "Minimize third-party usage",
"description": "Third-party code can significantly impact load performance. Limit the number of redundant third-party providers and try to load third-party code after your page has primarily finished loading. [Learn more](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/loading-third-party-javascript/).",
"score": 1,
"scoreDisplayMode": "binary",
Expand Down
4 changes: 2 additions & 2 deletions proto/sample_v2_round_trip.json
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@
"id": "critical-request-chains",
"score": null,
"scoreDisplayMode": "informative",
"title": "Minimize Critical Requests Depth"
"title": "Avoid chaining critical requests"
},
"custom-controls-labels": {
"description": "Custom interactive controls have associated labels, provided by aria-label or aria-labelledby. [Learn more](https://web.dev/custom-controls-labels/).",
Expand Down Expand Up @@ -2607,7 +2607,7 @@
"id": "third-party-summary",
"score": 1.0,
"scoreDisplayMode": "binary",
"title": "Third-Party usage"
"title": "Minimize third-party usage"
},
"time-to-first-byte": {
"description": "Time To First Byte identifies the time at which your server sends a response. [Learn more](https://web.dev/time-to-first-byte).",
Expand Down