Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: import translations from tc/ #9577

Merged
merged 2 commits into from
Aug 19, 2019
Merged

i18n: import translations from tc/ #9577

merged 2 commits into from
Aug 19, 2019

Conversation

exterkamp
Copy link
Member

@exterkamp exterkamp commented Aug 19, 2019

Summary
Import new tc/ translations. This is the first round trip with placeholders! 🎉 This will fix all points in i18n guffaws, also check out en-XA, it works again! This also includes the first (#9084) web.dev links in a11y! And adds best-practices!

Related Issues/PRs
fixes: #9197
helps: #9492

@brendankenny
Copy link
Member

This is the first round trip with placeholders! 🎉 This will fix all points in i18n guffaws, also check out en-XA, it works again! This also includes the first (#9084) web.dev links in a11y!

also adds best practices, hence the lr bundle size increase.

1.23MB > maxSize 1.1MB (gzip)

will need to bump that for this PR

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo! 🎉 🎉

LGTM with bundlesize bump

@paulirish
Copy link
Member

she's a beauty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Collection of i18n Markdown Guffaws 😭😭😭
4 participants