Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deduplicate yarn.lock dependencies #9600

Merged
merged 1 commit into from
Aug 23, 2019
Merged

chore: deduplicate yarn.lock dependencies #9600

merged 1 commit into from
Aug 23, 2019

Conversation

wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented Aug 23, 2019 •
edited
Loading

Summary
I've spent a few hours cleaning up all duplicates of yarn.lock to make this repo a little bite nicer and smaller.

Just kidding I used an awesome tool from atlassian called yarn-deduplicate. It automatically cleans up yarn.lock.

patrickhulce
patrickhulce approved these changes Aug 23, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paulirish
paulirish approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every update is for a more recent package version.
lgtm.

@paulirish paulirish merged commit a415a23 into GoogleChrome:master Aug 23, 2019
brendankenny
brendankenny reviewed Aug 23, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@brendankenny brendankenny mentioned this pull request Aug 23, 2019
Merged
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@wardpeet @paulirish
chore: deduplicate yarn.lock dependencies (#9600)
24d8cd1
@wardpeet wardpeet deleted the chore/cleanup-yarn-lock branch November 8, 2019 23:29
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny left review comments

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wardpeet @paulirish @brendankenny @patrickhulce @googlebot