build(smokehouse): bundle smoke test runner #9873
Conversation
agreed, and that makes the testing system more fragile and harder to change in the future. Doing some decoupling to make it so non-googlers don't have to care about the tests they can't see was part of the motivation for #9843, and I think we should consider making decisions on the architecture proposed there as a blocker for this. |
|
The first post was updated with the relevant doc (@patrickhulce, nothing has changed since you last reviewed the doc) |
|
I'm not sure I'm the best reviewer for this PR @connorjclark since I have no insight into the companion consumption code. Any googlers want to swap PRs for this one @exterkamp @paulirish ? |
| * @param {Smokehouse.FirehouseOptions} options | ||
| */ | ||
| async function runFirehouse(options) { | ||
| const {smokehouse, urlFilterRegex, skip, modify} = options; |
There was a problem hiding this comment.
these all get set by the person consuming firehouse, correct?
build/build-firehouse.js
Outdated
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const distDir = path.join(__dirname, '..', 'dist'); |
There was a problem hiding this comment.
I find it humorous how this one is carefully crafted with path and then the others are just concated and then relative to cwd 😆
There was a problem hiding this comment.
it isn't the only build file that does this :) if it hasn't annoyed anyone enough to fix it yet...
|
@exterkamp has seen the internal usage, so wdyt shane? |
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
… into firehouse-bundle
connorjclark
changed the title
Bundles smokehouse for consumption in LR / DevTools.
Googlers: see cl/275909869 / doc