Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(viewer): don't override puppeteer's chromium #9877

Merged
merged 11 commits into from
Oct 24, 2019
Merged

tests(viewer): don't override puppeteer's chromium #9877

merged 11 commits into from
Oct 24, 2019

Commits on Oct 18, 2019

  1. misc: add chrome version field to bug report template

    @connorjclark
    connorjclark authored Oct 18, 2019
    Configuration menu
    Copy the full SHA
    164a42a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. tests(viewer): don't override puppeteer's chromium 

    This test is currently failing in master.

The viewer's puppeteer test doesn't work with Chrome 78, and neither does the latest puppeteer (1.20.0).

Puppeteer ships with a specific Chromium revision, and is only meant to work with that, so we shouldn't override it.
    @connorjclark
    connorjclark authored Oct 23, 2019
    Configuration menu
    Copy the full SHA
    0c28320 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'connorjclark-patch-1' of github.com:GoogleChrome/lighth… 

    …ouse into connorjclark-patch-1
    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    2fb7c28 View commit details
    Browse the repository at this point in the history

  3. download pup chr

    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    5b65636 View commit details
    Browse the repository at this point in the history

  4. tmp change

    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    ca383f5 View commit details
    Browse the repository at this point in the history

  5. Revert "tmp change" 

    This reverts commit ca383f5.
    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    b69c27a View commit details
    Browse the repository at this point in the history

  6. test

    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    570f564 View commit details
    Browse the repository at this point in the history

  7. skips

    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    9080bbe View commit details
    Browse the repository at this point in the history

  8. unset

    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    97f662c View commit details
    Browse the repository at this point in the history

  9. fix

    @connorjclark
    connorjclark committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    4819d9d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. comment

    @connorjclark
    connorjclark committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    dde3791 View commit details
    Browse the repository at this point in the history