bundling pubads for devtools #9936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
brendankenny
reviewed
Nov 7, 2019
| @@ -40,6 +40,7 @@ function runLighthouseInWorker(port, url, flags, categoryIDs) { | |||
| // Default to 'info' logging level. | |||
| flags.logLevel = flags.logLevel || 'info'; | |||
| flags.channel = 'devtools'; | |||
| global.devtools = true; | |||
There was a problem hiding this comment.
haha, yes, this is terrible :P but at least it works!
I'll play around with it and see what I can do, but I think you're right that require.resolve() just fundamentally isn't going to work for this...
devtools-bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Nov 8, 2019
Lighthouse master has breaking pre-6.0 changes, so we are cherry-picking a few things on top of 5.6.0. Cherry-picks from master: - d53284cf12e680cbe6a12429cc1c6c4219e7ef43 icu error - 466bd6f79e57950d736de5edfa9642a40f1100fd verbose i18n - 7c16d346593d86b33945d75a996829e1a25b4fed flatten PRs not yet in master, but merged into 5.7.0:: - GoogleChrome/lighthouse#9377 internalDisableDeviceScreenEmulation - GoogleChrome/lighthouse#9936 Bundling pubads Screenshot: https://imgur.com/a/XuHkgWk Bug: 772558 Change-Id: I4a03965ec879119a88faf40dbdca471a9a33e794 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1900472 Commit-Queue: Connor Clark <cjamcl@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org>
babot
pushed a commit
to binaryage/dirac
that referenced
this pull request
Nov 8, 2019
Lighthouse master has breaking pre-6.0 changes, so we are cherry-picking a few things on top of 5.6.0. Cherry-picks from master: - d53284cf12e680cbe6a12429cc1c6c4219e7ef43 icu error - 466bd6f79e57950d736de5edfa9642a40f1100fd verbose i18n - 7c16d346593d86b33945d75a996829e1a25b4fed flatten PRs not yet in master, but merged into 5.7.0:: - GoogleChrome/lighthouse#9377 internalDisableDeviceScreenEmulation - GoogleChrome/lighthouse#9936 Bundling pubads Screenshot: https://imgur.com/a/XuHkgWk Bug: 772558 Change-Id: I4a03965ec879119a88faf40dbdca471a9a33e794 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1900472 Commit-Queue: Connor Clark <cjamcl@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling this patch (combined with #9377) is confirmed to work in DevTools.
Basically, just expose plugin modules by their regular, normalized paths (sans any relative path components or
node_modules). Then directlyrequireplugins if we are in devtools (skip the custom resolving we do).@brendankenny to figure out if this is the best approach :)