INP breakdown and LoAF integration with web-vitals v4 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
commented
Apr 30, 2024
|
Not going to land this until web-vitals v4 lands, but think it's ready for review now. Thanks @philipwalton for double checking the interaction stuff already! |
tunetheweb
commented
May 1, 2024
philipwalton
reviewed
May 2, 2024
philipwalton
reviewed
May 3, 2024
philipwalton
approved these changes
May 6, 2024
rviscomi
approved these changes
May 8, 2024
|
Thanks for all approvals. Will update and merge after v4 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the upcoming v4 build of web-vitals which allows INP breakdown and LoAF integration.
This allows us to do things like this:
For Interaction the breakdowns is too complex to repeat all the web-vitals.js code and maintain it separately, but they can have LoAFs: