Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FID #185

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Remove FID #185

merged 3 commits into from
Sep 9, 2024

Conversation

rviscomi
Copy link
Member

@rviscomi rviscomi commented Sep 8, 2024

No description provided.

@rviscomi rviscomi requested a review from tunetheweb September 8, 2024 19:50
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few suggestions. Take 'em or leave 'em :-)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rviscomi rviscomi merged commit 53edd6d into main Sep 9, 2024
3 checks passed
@rviscomi rviscomi deleted the rm-fid branch September 9, 2024 14:54
@rviscomi rviscomi mentioned this pull request Sep 9, 2024
@@ -253,9 +249,6 @@
break;
case 'INP':
case 'Interaction':
case 'FID':
formattedValue = millisecondsFormatter.format(metric.value);
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrgh, this change is incorrect!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch good spot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants