Shows a message for LCP only tab is loaded in background #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're okay with this approach, let me know and I can also add the message to the HUD overlay 🕺 |
|
This is great @housseindjirdeh. Just tested it out with a number of different background tab scenarios (and switching back to loading normal tabs) and the experience appears to report backgrounding correctly. Appreciate your time on this. Please feel free to add this to the overlay in a separate PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
Instead of relying on Page Visibility, this just checks for tabs that are updated but not active at the same time (and stores a boolean that
popup.jschecks for before displaying a message).If you think the message should live within a toggle or
<details>, I can update this!Gif