Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

content: Add historical scoring info and deprecations for Lighthouse 6.0 #1630

Closed
7 of 10 tasks
kaycebasques opened this issue Oct 8, 2019 · 5 comments · Fixed by #1660
Closed
7 of 10 tasks

content: Add historical scoring info and deprecations for Lighthouse 6.0 #1630

kaycebasques opened this issue Oct 8, 2019 · 5 comments · Fixed by #1660
Assignees
Labels
P0 An urgent priority task. Drop everything and work on this!
Milestone

Comments

@kaycebasques
Copy link
Contributor

kaycebasques commented Oct 8, 2019

Author: @kaycebasques
Reviewer: @paulirish

Tasks

Target publish date: 2019-10-17 (Chrome 79 Branch Point)

  • Check this box if this is a hard deadline.
  • Check this box if you'd like your reviewer to fix grammar and punctuation issues for you.

Process

Check out the web.dev writing process.

When you're ready, make a copy of this template
and fill in the proposal and outline sections. When you're finished, drop a link
to the doc in the 1st step below and check the box. A member of the web.dev team
will assign this ticket to themselves and work as your reviewer to help you
complete the remaining steps.

  • 1. I've done my proposal
  • 2. Proposal approved — reviewer checks this
  • 3. I've added a draft to my proposal doc
  • 4. Draft approved — reviewer checks this
  • 5. I've submitted a pull request Fix #1630 #1660
  • 6. Pull request approved — reviewer checks this
@kaycebasques kaycebasques added the content Issues related to content label Oct 8, 2019
@kaycebasques kaycebasques self-assigned this Oct 8, 2019
@kaycebasques kaycebasques added CDS P0 An urgent priority task. Drop everything and work on this! and removed content Issues related to content labels Oct 8, 2019
@kaycebasques kaycebasques added this to the CDS19 Wave 1 milestone Oct 8, 2019
@paulirish
Copy link
Member

@kaycebasques i have some WIP on this. Perhaps we can collab?

@carolrivero
Copy link

Please confirm who the reviewer is on this one. Thanks.

@kaycebasques
Copy link
Contributor Author

@paulirish I wouldn't have it any other way. I'll write and you can review.

@kaycebasques
Copy link
Contributor Author

kaycebasques commented Oct 12, 2019

@paulirish #1660 is my first pass, please leave feedback and then assign this issue back to me

P.S. I should've done the work on googlechrome/web.dev so that you could push edits, but didn't think about that, so I just gave you collab access to my fork so you should be able to push to kaycebasques/web.dev.

@kaycebasques kaycebasques changed the title content: Lighthouse 6.0 metrics updates content: Add historical scoring info and deprecations for Lighthouse 6.0 Oct 15, 2019
@kaycebasques
Copy link
Contributor Author

Paul reviewed the PR 2 days ago, so next step is for me to incorporate feedback.

kaycebasques pushed a commit that referenced this issue Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0 An urgent priority task. Drop everything and work on this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants