This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
reorder caching so images are cached after 1st load #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for web-dev-staging ready! Built with commit bcca896 |
|
hmmmmmmmmmmmmmmmmm did you notice the percy failure? Not sure why that is... |
|
@robdodson I kicked Percy. I reckon it's random whether the lower image loads in time. |
robdodson
force-pushed
the
sw-precaching
branch
from
aa1c6a1
to
bcca896
Compare
|
Rebasing so I can verify this works on netlify. I think the deploy was running the old (busted) loader.js code. |
robdodson
force-pushed
the
sw-precaching
branch
from
59f165d
to
bcca896
Compare
robdodson
approved these changes
Mar 20, 2020
|
Seems to be working fine on netlify. I tried increasing the wait time on percy to 5 seconds but it still didn't load that image so I'm thinking we'll have to try something else. Maybe we don't load that footer image when we're in a test environment. Percy's great, but if it's flaky folks will complain. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the issue raised over in Workbox.
This isn't specifically tracked but I noticed it while working on JS issues. Images that we aggressively precache (anything in /images/*) weren't be served while offline, because the runtime handler was winning and claiming nothing was found.
As per the other bug: