-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
Still a draft! :)
Would you like me to create a new folder so that I can add my img assets? |
yep you'll want to create a directory called:
and you can put your images inside of it. Your markdown file can be renamed to So you should end up with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an initial pass. Looks pretty good so far, but I think a few items weren't included in the PR.
Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>
Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>
Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>
Co-Authored-By: Rob Dodson <robdodson@users.noreply.github.com>
hey @egsweeny let me know when you're ready for another review. |
Howdy @robdodson ! I think I'm ready for another review. :) Thank you! |
TMS is a ‘Think with Google’ tool that allows you to compare your FCP to that of your competitors and estimate the monetary value of improving your site’s performance. | ||
|
||
### Mobile Site Speed: Field Data, FCP Only, Site Level | ||
The first part of the report, the mobile site speed seconds figure === First Contentful Paint (FCP) of the origin from CrUX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if these ===
could be replaced with "equals", or something along those lines. Currently they read a tad rushed.
@mfriesenhahn are you free to give this one a look? |
Just incorporated the final changes suggested by @robdodson ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm pretty confused still about scoring. It's late afternoon, and I need to go for a run, so maybe the brain isn't working. That said, I think a white-board session explaining the table and then how it is used in each tool would really help. I'm kind of lost. But can maybe help with words once I understand what the blog post is trying to do.
- performance | ||
--- | ||
|
||
Load is not a single point in time- there are multiple moments during the load experience that can affect whether a user perceives it as "fast", and if you just focus on one you might miss bad experiences that happen during the rest of the time. **This is why we generally use multiple metrics blended together to create our performance scores;** but different tools use different metrics and different weighted blends. This can be frustrating when you're looking for a source of truth about how fast your website is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is a little big, has some run-on sentences, and a little bit of formatting strangeness. Small changes reflected here:
Load is not a single point in time. There are multiple moments during the load experience that can affect whether a user perceives it as "fast". If you focus on only one of these moments, you might miss bad experiences that happen the rest of the time. This is why we generally use multiple metrics blended together to create our performance scores. Different tools use different metrics and different weighted blends.
--- | ||
|
||
Load is not a single point in time- there are multiple moments during the load experience that can affect whether a user perceives it as "fast", and if you just focus on one you might miss bad experiences that happen during the rest of the time. **This is why we generally use multiple metrics blended together to create our performance scores;** but different tools use different metrics and different weighted blends. This can be frustrating when you're looking for a source of truth about how fast your website is. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to move sentence "This can be frustrating" to be the starting sentence of the next paragraph. And reword it a little bit:
When you're looking for a source of truth about how fast your website is, it can be frustrating seeing different performance scores from different tools.
|
||
Load is not a single point in time- there are multiple moments during the load experience that can affect whether a user perceives it as "fast", and if you just focus on one you might miss bad experiences that happen during the rest of the time. **This is why we generally use multiple metrics blended together to create our performance scores;** but different tools use different metrics and different weighted blends. This can be frustrating when you're looking for a source of truth about how fast your website is. | ||
|
||
This post serves to explain the reasons that there are differences in performance scores between three Google tools: [Test My Site (TMS)](https://www.thinkwithgoogle.com/intl/en-gb/feature/testmysite), [PageSpeed Insights (PSI)](https://developers.google.com/speed/pagespeed/insights/), and [Lighthouse (LH)](https://developers.google.com/web/tools/lighthouse/). This document does **not** detail other differences in the tools, such as server run locations, network throttling presets, score variance between runs, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: suggestion to replace 'document' with 'post' to be consistent.
|
||
## Terminology | ||
|
||
Various terms about speed/performance are referenced in our tools. We want to start off with some clarification of how these terms are used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest replacing the first two sentences with one that's something like:
"The terms page speed and site speed are referenced throughout these tools:"
It's short and to the point, and I think it does enough work.
- **Page speed** refers to the speed of an individual page on your site (URL level). | ||
- **Site speed** refers to the speed of all of the pages on your site (origin level). | ||
|
||
It is important to note that "performance" or "speed" is not to be defined by a single metric (i.e. [First Contentful Paint (FCP)](/first-contentful-paint/), [Time to Interactive (TTI)](/interactive/), etc.). This is motivated by several considerations, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to remove 'i.e.' and 'etc.'. Start off with 'such as'.
{% endAside %} | ||
|
||
TMS uses only FCP (from both Lighthouse and from the CrUX) to provide both site and page speed scores. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are introducing CrUX here, and not all developers will know what that is?
<td><a href="https://www.thinkwithgoogle.com/intl/en-gb/feature/testmysite">Test My Site</a></td> | ||
<td>Lab & Field</td> | ||
<td>FCP**</td> | ||
<td>FCP**</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoah, this table scares me. Have we explained lab vs field? What do all the abbreviations mean? Asterix descriptions also are a bit vague. I completely understand how hard it is to make this table work! But I do think it might need a few gos.
|
||
Site speed is the speed of **all the pages** that make up your site. | ||
|
||
<figure class="w-figure"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, as I move through the various tool descriptions and scoring, I continue to remain lost along the way. And a lot of that has to do with not fully understanding the table. I'm really lost here.. and trying to understand what you are trying to say. I wonder if maybe this could be solved with a chat explaining it to me, and me then word-smithing that explanation? Should I set up some time?
|
||
### Site Speed Tools: Field Data, FCP Only, Site Level | ||
In the second part of the report, the mobile site speed seconds figure === First Contentful Paint (FCP) of the origin from CrUX. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See general comment above-- I'm still lost here. Lots of abbreviations and assumptions around field and lab, etc.
</figcaption> | ||
</figure> | ||
|
||
### PSI Field Data: Field Data, FCP & FID, URL & Origin Level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoah all the things in the title.
@Meggin I'd love to set up some time to chat with you about this, to share my intentions about meaning and leveraging your brilliant wordsmithing abilities to convey it to all! |
@egsweeny LMK if we still need this content and we'll set aside some time in the future to address it I backed up the content here: https://drive.google.com/a/google.com/file/d/1bVfz4awdeobcLTyWt4SA7B2bXNw8rHcA/view?usp=sharing |
This pull request adds a new:
Does your content tell a user how to fix a Lighthouse audit?
Have you added the Lighthouse audit ID to your YAML?
Does your content reference any Glitch projects?
Have you read the wiki on working with Glitch?
Have you added the Glitch project to our team page?
![hero](https://user-images.githubusercontent.com/40670445/58956350-6a544180-879e-11e9-9b8e-37f00f83fa4f.jpg)