Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unsortable columns. #995

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

jrobbins
Copy link
Collaborator

This is progress on #790.

In this PR:

  • Add an optional unsortable field to CELL_DEFS. None of the existing columns sets it to true, but it will be used by the upcoming availability column.
  • Render unsortable columns without hover highlighting and without a link or direction arrow icon.

@jrobbins jrobbins requested a review from jcscottiii December 18, 2024 21:18
@KyleJu
Copy link
Collaborator

KyleJu commented Dec 18, 2024

Feel free to go ahead with the implementation. I will incorporate this PR into mine in #992. cc @jcscottiii

@jrobbins jrobbins added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 22f741b Dec 19, 2024
6 checks passed
@jrobbins jrobbins deleted the 20241218-unsortable-columns branch December 19, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants