Skip to content

Commit

Permalink
Switch the minimum supported node version to 10 (#2462)
Browse files Browse the repository at this point in the history
* Switch to node 10

* Win should use Node 10
  • Loading branch information
jeffposnick authored Apr 24, 2020
1 parent d2409a6 commit 5f29489
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: 8.x
node-version: 10.x

- name: Setup
run: |
# Use `npm i` to work around https://github.com/npm/cli/issues/558
npm i
npm ci
gulp build
- run: npx gulp test-node
Expand Down
2 changes: 1 addition & 1 deletion gulp-tasks/utils/build-node-package.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module.exports = (packagePath) => {
['@babel/preset-env', {
targets: {
// Change this when our minimum required node version changes.
node: '8.0',
node: '10.0',
},
}],
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "workbox",
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"scripts": {
"bot": "pr-bot",
Expand Down
2 changes: 1 addition & 1 deletion packages/workbox-build/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"file manifest"
],
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"author": "Google's Web DevRel Team",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/workbox-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"build"
],
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"scripts": {
"prepublish": "gulp build-packages --package workbox-cli"
Expand Down
2 changes: 1 addition & 1 deletion packages/workbox-webpack-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"build"
],
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
},
"dependencies": {
"@babel/runtime": "^7.5.5",
Expand Down

0 comments on commit 5f29489

Please sign in to comment.