You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Working on #1095 made me realize that there's some cleanup to be done related to what we accept for runtimeCaching.options in v3. In v2, we basically supported the same set of options that sw-precache supported (plus a plugins property that could be used to provide additional lifecycle callback handlers).
As of what's checked in to the v3 branch today, our joi parameter validation looks like
This is a departure from what we supported in v2/sw-precache, but there wasn't previously a breaking-change issue tracking that, so if nothing else, this serves to keep track of that.
But I realize that we could tweak things further in v3, by
supporting runtimeCaching.options.broadcastUpdate, which would configure a workbox.broadcastUpdate.Plugin instance.
renaming runtimeCaching.options.cacheExpiration to expiration, to reflect the fact that the module is exposed as workbox.expiration.
(Re-adding support for runtimeCaching.options.networkTimeoutSeconds, which I inadvertently removed from the joi config.)
So, I'm proposing that in v3 we'd support a full set of configuration that looked like:
Library Affected:
workbox-build
Working on #1095 made me realize that there's some cleanup to be done related to what we accept for
runtimeCaching.options
in v3. In v2, we basically supported the same set of options thatsw-precache
supported (plus aplugins
property that could be used to provide additional lifecycle callback handlers).As of what's checked in to the v3 branch today, our
joi
parameter validation looks likeworkbox/packages/workbox-build/src/entry-points/options/common-generate-schema.js
Lines 40 to 51 in 7a74459
This is a departure from what we supported in v2/
sw-precache
, but there wasn't previously abreaking-change
issue tracking that, so if nothing else, this serves to keep track of that.But I realize that we could tweak things further in v3, by
workbox.broadcastUpdate.Plugin
instance.runtimeCaching.options.cacheExpiration
toexpiration
, to reflect the fact that the module is exposed asworkbox.expiration
.joi
config.)So, I'm proposing that in v3 we'd support a full set of configuration that looked like:
Any concerns there?
The text was updated successfully, but these errors were encountered: